Support for multiple highlights #5038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
tsmaeder
force-pushed
the
4343_multiple_highlights
branch
from
9e85eb6
to
7291efc
Compare
evidolob
approved these changes
Jun 15, 2017
|
@tsmaeder could you rebase this PR ? |
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
force-pushed
the
4343_multiple_highlights
branch
from
7291efc
to
961e713
Compare
|
ci-build |
vparfonov
approved these changes
Jul 3, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2983/ |
benoitf
added
kind/bug
tsmaeder
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mäder tmader@redhat.com
What does this PR do?
This PR adds support for multiple document highlights in LSP based editors. It also fixes incorrect handling of line/char based text positions.
What issues does this PR fix or reference?
#4343
Changelog
Added support for showing multiple document highlights in LSP based editors.
Release Notes
N/A
Docs PR
N/A