CHE-4768. Fix receiving file tracking operation calls from client at refactoring #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2561/ |
vzhukovs
reviewed
May 11, 2017
|
|
||
| store.dispose(source.getLocation(), !source.isFile()); //TODO: need to be tested | ||
| return clientServerEventService.sendFileTrackingSuspendEvent().thenPromise(success -> { | ||
| eventBus.fireEvent(newFileTrackingSuspendedEvent()); |
There was a problem hiding this comment.
Do we really need this event bus event then?
vzhukovs
reviewed
May 11, 2017
| if (source.isProject() && source.getLocation().segmentCount() == 1) { | ||
| return ps.getProjects().then((Function<List<ProjectConfigDto>, Resource>)updatedConfigs -> { | ||
| clientServerEventService.sendFileTrackingResumeEvent().then(arg -> { | ||
| eventBus.fireEvent(newFileTrackingResumedEvent()); |
|
@vzhukovskii You are right - we can avoid to use FileTrackingEvent on client side. I've deprecated this class and updated the pull request. Thank you! |
vzhukovs
approved these changes
May 15, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2593/ |
…refactoring Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
|
@vparfonov I've fixed conflicts and updated the pull request |
vparfonov
approved these changes
May 17, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2618/ |
slemeur
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko rnikitenko@codenvy.com
What does this PR do?
What issues does this PR fix or reference?
#4768
Changelog
Fix receiving file tracking operation calls from client at refactoring