CHE-4910:Fix catching exception in case invalid POM to prevent fail start workspace #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 5, 2017 16:21
Fix dependency on che-plugin-pullrequest-server in should be only in ws-agent. Improve maven attribute resolving previos we always read them from pom.xml but MavenProjectManager already has all information about regitered projects Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
|
Build # 2574 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2574/ to view the results. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…tart workspace (eclipse-che#5066) * Fix catching exception in case invalid POM. Fix dependency on che-plugin-pullrequest-server in should be only in ws-agent. Improve maven attribute resolving previos we always read them from pom.xml but MavenProjectManager already has all information about regitered projects Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Parfonov vparfonov@codenvy.com
What does this PR do?
Fix dependency on che-plugin-pullrequest-server in should be only in ws-agent.
Improve maven attribute resolving previous we always read them from pom.xml but MavenProjectManager already has all information about registered projects, in case we not found given project we still goto parse pom.xml
What issues does this PR fix or reference?
#4910
Changelog
Fix catching exception in case invalid POM to prevent fail start workspace
Release Notes
N/A
Docs PR