CHE-4731 improve editor behavior for design a new factory from a template #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build # 2587 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2587/ to view the results. |
ashumilova
added
the
kind/bug
olexii4
changed the title
ashumilova
approved these changes
May 15, 2017
akurinnoy
approved these changes
May 15, 2017
…late Signed-off-by: Oleksii Orel <oorel@codenvy.com>
benoitf
approved these changes
May 15, 2017
|
Build # 2590 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2590/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Orel oorel@codenvy.com
What does this PR do?
Remove reload template condition in case with an error during factory creating. Add condition for JSONlint editor errors for 'create a new factory from a template' flow.
What issues does this PR fix or reference?
#4731
#4651
Changelog
-- Add condition for JSONlint editor errors for 'create a new factory from a template' flow.
-- Remove reload template condition in case with an error during factory creating.
Release Notes
N/A
