fix CHE custom properties usage #5103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
approved these changes
May 16, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2605/ |
benoitf
approved these changes
May 17, 2017
benoitf
added
the
kind/bug
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes using custom properties in CHE
Before these changes any custom properties added using CLI addon feature for CHE were ignored. I also found useles section in entrypoint.sh which is seems supposed to be used as default config but all defaults we are set though ENV vars, so we don't need it and it also was breaking possibility to add custom props due to override
CHE_LOCAL_CONF_DIR.What issues does this PR fix or reference?
this is needed for #5077 and https://github.com/codenvy/enterprise/issues/65
Changelog
Fixes using custom properties in CHE