CODENVY-2199: Do not snapshot /tmp folder #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
|
Is this true for Che as well? Or only Codenvy? |
|
@bmicklea for both Che and Codenvy |
|
This will require docs changes that will have to be approved before I can approve this PR: eclipse-che/che-docs#232 |
|
@slemeur do you think we need to mention this in the release notes? |
|
@bmicklea : Yes I think we can have a section for the enhancement of the snapshotting policy. (based on the docs) |
slemeur
added
the
kind/enhancement
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
|
Build # 2646 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2646/ to view the results. |
bmicklea
approved these changes
May 23, 2017
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
garagatyi
approved these changes
May 24, 2017
skabashnyuk
approved these changes
May 24, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2655/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents adding
/tmpfolder from a workspace container into a snapshot.Added ability to specify a user for docker exec.
What issues does this PR fix or reference?
codenvy/codenvy#2199
Changelog
Ignore
/tmpfolder when creating workspace snapshot.Release Notes
Snapshots No Longer Capture
tmpWe have implemented a small but important change in how we handle snapshots. In order to speed up snapshotting when stopping a workspace, and snapshot restore when workspaces startup we are no longer snapshotting the
tmpdirectory. In many cases this has trimmed >50% of the total snapshot size and noticeably increased the speed of snapshotting and restoring.Docs PR
eclipse-che/che-docs#232