Remove deprecated factory methods #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuznyetsov
added
the
kind/task
mkuznyetsov
changed the title
|
Updated PR to remove deprecated method completely from the code |
|
Build # 2674 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2674/ to view the results. |
|
Build # 2685 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2685/ to view the results. |
mkuznyetsov
changed the title
mkuznyetsov
changed the title
skabashnyuk
approved these changes
May 29, 2017
|
Changed PR to remove all currently deprecated factory methods: |
|
Build # 2686 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2686/ to view the results. |
bmicklea
approved these changes
May 29, 2017
added 2 commits
May 29, 2017 15:05
skabashnyuk
approved these changes
May 29, 2017
|
Build # 2694 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2694/ to view the results. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed deprecated methods:
What issues does this PR fix or reference?
#5060
Changelog
Removed deprecated methods from FactoryService
Release Notes
Docs PR