Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process exit code to MachineProcess & process_died event #5205

Merged
merged 1 commit into from
May 26, 2017

Conversation

voievodin
Copy link
Contributor

@voievodin voievodin commented May 26, 2017

What does this PR do?

Adds exit code to the process struct & process_died event.
Example of REST API response when getting a dead process GET /process/1

{
  "pid": 1,
  "name": "test",
  "commandLine": "echo hello",
  "type": "test",
  "alive": false,
  "nativePid": 1833,
  "exitCode": 0
}

Example of process_died jsonrpc event:

{
  "jsonrpc": "2.0",
  "method": "process_died",
  "params": {
    "time": "2017-05-26T10:19:09.056360416+03:00",
    "pid": 2,
    "nativePid": 2524,
    "name": "print",
    "commandLine": "printf \"1\n2\n3\"",
    "exitCode": 0
  }
}

What issues does this PR fix or reference?

Resolves #5147

Changelog

Added exit code to the response of process REST/WS API and to the process_died event body

@voievodin voievodin self-assigned this May 26, 2017
@voievodin voievodin requested a review from akorneta May 26, 2017 07:24
@voievodin voievodin merged commit 25c4a3e into master May 26, 2017
@voievodin voievodin deleted the core_process_add_exit_code branch May 26, 2017 08:10
@codenvy-ci
Copy link

Build # 2679 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2679/ to view the results.

@ashumilova ashumilova added this to the 5.12.0 milestone May 29, 2017
@slemeur slemeur added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add process exit code to the core/process process_died event
5 participants