Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Authorization header instead of session-access-key cookie #5210

Merged
merged 1 commit into from
May 26, 2017

Conversation

voievodin
Copy link
Contributor

CSRF protection codenvy/codenvy#2213 affected CLI.
CLI or any other client different from web-browser SHOULD NOT use cookies for authorization but SHOULD use either Authorization header or query parameter.

@voievodin voievodin self-assigned this May 26, 2017
@voievodin voievodin requested review from skabashnyuk and removed request for benoitf May 26, 2017 12:10
@codenvy-ci
Copy link

@riuvshin
Copy link
Contributor

riuvshin commented May 26, 2017

fix tested, works like a charm!

@riuvshin riuvshin added this to the 5.11.1 milestone May 26, 2017
@voievodin voievodin merged commit a16ddd3 into master May 26, 2017
@voievodin voievodin deleted the fix_cli_csrf branch May 26, 2017 14:42
@riuvshin riuvshin added the kind/bug Outline of a bug - must adhere to the bug report template. label May 26, 2017
@riuvshin riuvshin modified the milestones: 5.11.2, 5.11.1 May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants