Update lsp4J lib to newer version. #5292

AndrienkoAleksandr · 2017-06-07T23:28:10Z

What does this PR do?

Update lsp4j to 0.2.0 version

Fix bugs in language server dto generator. This bugs is not critical for current lsp4j 0.1.2 library. But dto generation fails if we update this library to 0.2.0. Fix some typos. Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>

Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>

AndrienkoAleksandr · 2017-06-07T23:28:55Z

Depends on #5290

codenvy-ci · 2017-06-07T23:53:46Z

Build # 2752 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2752/ to view the results.

AndrienkoAleksandr · 2017-06-08T11:58:00Z

Depends on https://github.com/eclipse/che-dependencies/compare/CHE-4991

codenvy-ci · 2017-06-08T17:58:16Z

Build # 2762 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2762/ to view the results.

tsmaeder · 2017-06-19T15:29:16Z

PHP hover support is currently broken until lsp4j is updated (hover contains MarkedString instances, which are not supported on 0.1.2

…e into updateLSP4Jlib Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com> # Conflicts: # wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/service/TextDocumentService.java

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

benoitf · 2017-06-29T14:58:58Z

Wip on the title should be removed no ?

codenvy-ci · 2017-06-29T16:57:21Z

Build # 2950 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2950/ to view the results.

…e into updateLSP4Jlib Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com> # Conflicts: # plugins/plugin-languageserver/che-plugin-languageserver-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/LanguageServerExtension.java # plugins/plugin-languageserver/che-plugin-languageserver-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/editor/codeassist/CompletionItemBasedCompletionProposal.java # plugins/plugin-languageserver/che-plugin-languageserver-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/editor/codeassist/LanguageServerCodeAssistProcessor.java # wsagent/che-core-api-languageserver/pom.xml # wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/launcher/LanguageServerLauncher.java # wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/registry/ServerInitializerImpl.java # wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/service/TextDocumentService.java

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

codenvy-ci · 2017-07-13T07:19:13Z

Build # 3056 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3056/ to view the results.

…e into updateLSP4Jlib Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com> # Conflicts: # wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/registry/ServerInitializerImpl.java # wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/service/TextDocumentService.java

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

tsmaeder · 2017-07-13T09:36:11Z

...eserver-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/hover/HoverProvider.java

-                hover.setContent(content);
-
-                return hover;
+        Promise<OrionHoverOverlay> then = promise.then((Function<Hover, OrionHoverOverlay>)arg -> {


I think writing `(Hover arg)->....' would make the generic types clear and it feels nicer than a cast.

tsmaeder · 2017-07-13T09:39:38Z

...eserver-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/hover/HoverProvider.java

+                // plain markdown text
+                contents.add(dto.getLeft());
+            } else {
+                contents.add(dto.getRight().getLanguage());


I think the "language" field is supposed to help render the content, not be displayed. Should we simply ignore the tag if we don't properly handle it?

We(Orion) properly handle it

tsmaeder · 2017-07-13T09:43:39Z

...ver/src/main/java/org/eclipse/che/api/languageserver/registry/ServerCapabilitiesOverlay.java

@@ -113,11 +116,13 @@ public SignatureHelpOptions getSignatureHelpProvider() {
        return result;
    }

-    public TextDocumentSyncKind getTextDocumentSync() {
+    public Either<TextDocumentSyncKind, TextDocumentSyncOptions> getTextDocumentSync() {


Do we really need to merge the whole thing, or can we just return TextDocumentSyncKind here? I don't think we're doing anything on the client side with it.

But for new version of the LS we should support all sync options

tsmaeder · 2017-07-13T09:45:13Z

...eserver/src/main/java/org/eclipse/che/api/languageserver/registry/ServerInitializerImpl.java

+        if (CLIENT_CAPABILITIES == null) {
+            CLIENT_CAPABILITIES = new ClientCapabilities();
+            WorkspaceClientCapabilities workspace = new WorkspaceClientCapabilities();
+            workspace.setApplyEdit(false); //Change when support added


I believe we can omit anything that is false. I find it confusing to set stuff that is default anyway.

tsmaeder · 2017-07-13T09:46:25Z

...uageserver/src/main/java/org/eclipse/che/api/languageserver/service/TextDocumentService.java

@@ -99,8 +101,8 @@ public void configureMethods() {
        dtoToDtoList("references", ReferenceParams.class, LocationDto.class, this::references);
        dtoToDtoList("onTypeFormatting", DocumentOnTypeFormattingParams.class, TextEditDto.class, this::onTypeFormatting);

-        dtoToDto("completionItem/resolve", ExtendedCompletionItem.class, ExtendedCompletionItemDto.class, this::completionItemResolve);
-        dtoToDto("documentHighlight", TextDocumentPositionParams.class, DocumentHighlightDto.class, this::documentHighlight);
+        dtoToDto("completionItem/resolve", ExtendedCompletionItem.class, ExtendedCompletionItem.class, this::completionItemResolve);


Did you test this? Why is it different from the lines above (LocationDto, TextEditDto, etc.)?

codenvy-ci · 2017-07-13T11:03:45Z

Build # 3060 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3060/ to view the results.

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

codenvy-ci · 2017-07-13T11:29:09Z

Build # 3061 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3061/ to view the results.

* eclipse-che#5360 Upgrade LSP4J library version to 0.2.0 Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

AndrienkoAleksandr added 2 commits June 8, 2017 00:47

Fix bug in language server dto generator.

e931d99

Fix bugs in language server dto generator. This bugs is not critical for current lsp4j 0.1.2 library. But dto generation fails if we update this library to 0.2.0. Fix some typos. Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>

Update lsp4j to 0.2.0 version.

8ae5e2d

Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>

Improve handling completion.

52b3412

evidolob mentioned this pull request Jun 22, 2017

Upgrade LSP4J library version to 0.2.0 #5360

Closed

Merge branches 'master' and 'updateLSP4Jlib' of github.com:eclipse/ch…

a9de395

…e into updateLSP4Jlib Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com> # Conflicts: # wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/service/TextDocumentService.java

AndrienkoAleksandr mentioned this pull request Jun 23, 2017

Fix bug in language server dto generator. #5290

Closed

#5360 Upgrade LSP4J library version to 0.2.0

7348609

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

evidolob requested review from dkuleshov and vparfonov June 29, 2017 14:32

vparfonov approved these changes Jun 29, 2017

View reviewed changes

evidolob changed the title ~~[WIP] Update lsp4J lib to newer version.~~ Update lsp4J lib to newer version. Jun 29, 2017

dkuleshov approved these changes Jun 30, 2017

View reviewed changes

Yevhen Vydolob added 2 commits July 12, 2017 17:45

#5360 update according to master changes

1e324fe

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

Yevhen Vydolob added 3 commits July 13, 2017 10:48

#5360 set root uri in LS initialize params

d9e7e4c

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

#5360 remove unused import

6c2c572

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

tsmaeder reviewed Jul 13, 2017

View reviewed changes

#5360 code improvements

9d7e090

Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

evidolob self-assigned this Jul 14, 2017

evidolob merged commit 7b9c2a1 into master Jul 14, 2017

evidolob deleted the updateLSP4Jlib branch July 14, 2017 08:05

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017

Update lsp4J lib to newer version. (eclipse-che#5292)

d14d062

* eclipse-che#5360 Upgrade LSP4J library version to 0.2.0 Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>

jonahgraham mentioned this pull request Feb 15, 2018

CHE-8557: No Dto available for FormattingOptions #8784

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update lsp4J lib to newer version. #5292

Update lsp4J lib to newer version. #5292

AndrienkoAleksandr commented Jun 7, 2017

AndrienkoAleksandr commented Jun 7, 2017

codenvy-ci commented Jun 7, 2017

AndrienkoAleksandr commented Jun 8, 2017

codenvy-ci commented Jun 8, 2017

tsmaeder commented Jun 19, 2017

benoitf commented Jun 29, 2017

codenvy-ci commented Jun 29, 2017

codenvy-ci commented Jul 13, 2017

tsmaeder Jul 13, 2017

tsmaeder Jul 13, 2017

evidolob Jul 13, 2017

tsmaeder Jul 13, 2017

evidolob Jul 13, 2017

tsmaeder Jul 13, 2017

tsmaeder Jul 13, 2017

codenvy-ci commented Jul 13, 2017

codenvy-ci commented Jul 13, 2017

Update lsp4J lib to newer version. #5292

Update lsp4J lib to newer version. #5292

Conversation

AndrienkoAleksandr commented Jun 7, 2017

What does this PR do?

AndrienkoAleksandr commented Jun 7, 2017

codenvy-ci commented Jun 7, 2017

AndrienkoAleksandr commented Jun 8, 2017

codenvy-ci commented Jun 8, 2017

tsmaeder commented Jun 19, 2017

benoitf commented Jun 29, 2017

codenvy-ci commented Jun 29, 2017

codenvy-ci commented Jul 13, 2017

tsmaeder Jul 13, 2017

Choose a reason for hiding this comment

tsmaeder Jul 13, 2017

Choose a reason for hiding this comment

evidolob Jul 13, 2017

Choose a reason for hiding this comment

tsmaeder Jul 13, 2017

Choose a reason for hiding this comment

evidolob Jul 13, 2017

Choose a reason for hiding this comment

tsmaeder Jul 13, 2017

Choose a reason for hiding this comment

tsmaeder Jul 13, 2017

Choose a reason for hiding this comment

codenvy-ci commented Jul 13, 2017

codenvy-ci commented Jul 13, 2017