Thread dump for java debugger #5320

tolusha · 2017-06-09T12:05:03Z

What does this PR do?

Introduces thread feature for debugger (client side).
Adds implementation for java debugger.

What issues does this PR fix or reference?

#3708
#3712

Changelog

Adds thread dump feature for java debugger

Release Notes

Adds thread dump feature for java debugger

… of String

codenvy-ci · 2017-06-09T13:51:07Z

Build # 2773 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2773/ to view the results.

codenvy-ci · 2017-06-14T05:46:50Z

Build # 2809 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2809/ to view the results.

codenvy-ci · 2017-06-15T09:11:43Z

Build # 2822 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2822/ to view the results.

codenvy-ci · 2017-06-16T14:30:12Z

Build # 2831 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2831/ to view the results.

codenvy-ci · 2017-06-19T06:31:39Z

Build # 2838 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2838/ to view the results.

codenvy-ci · 2017-06-19T13:33:05Z

Build # 2844 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2844/ to view the results.

codenvy-ci · 2017-06-19T17:21:04Z

Build # 2848 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2848/ to view the results.

Signed-off-by: Oleksii Orel <oorel@redhat.com>

mmorhun · 2017-08-22T09:20:29Z

.../src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerResourceHandlerFactory.java

+
+/** @author Anatolii Bazko */
+@Singleton
+public class DebuggerResourceHandlerFactory {


I would avoid term Factory here, because factory is creational pattern. This class just returns one of registered or default object.

mmorhun · 2017-08-22T09:22:57Z

...lugin-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerView.java

@@ -38,12 +41,22 @@
    void onExpandVariablesTree();

    /**
-     * Performs any actions appropriate in response to the user having selected variable in
+     * Performs any actions appropriate in response to the user having selected variable in*


Probably asterisk is added occasionally.

mmorhun · 2017-08-22T09:26:28Z

...n-debugger-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/DebuggerViewImpl.java

+
+    for (int i = 0; i < threadDumps.size(); i++) {
+      ThreadDump td = threadDumps.get(i);
+      String item =


Consider usage of StringBuilder please.

mmorhun · 2017-08-22T09:35:01Z

...er-ide/src/main/java/org/eclipse/che/plugin/debugger/ide/debug/VariableTreeNodeRenderer.java

@@ -21,9 +21,10 @@
 import org.eclipse.che.ide.util.dom.Elements;

 /**
- * The rendered for debug variable node.
+ * Renders variable item the panel.


Commentary isn't clear to me.

mmorhun · 2017-08-22T11:17:19Z

...lugin-java-debugger-server/src/main/java/org/eclipse/che/plugin/jdb/server/JavaDebugger.java

+  }
+
+  @Override
+  public String evaluate(String expression, long threadId, int frameIndex)


The method above use lock to prevent simultaneous execution of this one. What if someone call this public method directly?

mmorhun · 2017-08-22T11:20:25Z

...lugin-java-debugger-server/src/main/java/org/eclipse/che/plugin/jdb/server/JavaDebugger.java

+  }
+
+  @Override
+  public SimpleValue getValue(VariablePath variablePath, long threadId, int frameIndex)


The same as with evaluate method. Someone could use it directly bypassing lock.

Locks are legacy. will be eliminated soon. The right way not to use them.

mmorhun · 2017-08-22T11:33:06Z

...gin-java-debugger-server/src/main/java/org/eclipse/che/plugin/jdb/server/model/JdbValue.java

+  public List<Variable> getVariables() {
+    if (variables.get() == null) {
+      synchronized (variables) {
+        if (variables.get() == null) {


Why did you check the same 2 lines above?

To avoid setting variables simultaneously in different threads.

mmorhun · 2017-08-22T11:35:17Z

...debugger-server/src/test/java/org/eclipse/che/plugin/jdb/server/EvaluateExpressionTest1.java

+ *
+ * @author Anatolii Bazko
+ */
+public class EvaluateExpressionTest1 {


Here and below. Why do you use 1 in the name of tests? If we have a few test classes, maybe we should give them better names?

I believe there will be a lot of tests using different compiled test classes.
Right now I don't see the appropriate names for them.

mmorhun · 2017-08-22T11:40:31Z

...plugin-java-debugger/che-plugin-java-debugger-server/src/test/resources/docker/entrypoint.sh

+javac -g org/eclipse/EvaluateExpressionTest1.java
+javac -g com/HelloWorld.java
+
+java -Xdebug -Xrunjdwp:transport=dt_socket,address=8001,server=y,suspend=y org.eclipse.ThreadDumpTest1


Maybe move common options into a variable?

Don't understand

I meant create a variable with -Xdebug -Xrunjdwp:transport=dt_socket,address=8001,server=y,suspend=y and then use it, for example:
java $args org.eclipse.ThreadDumpTest1
Easier to read. But think of better name, of course.

mmorhun · 2017-08-22T11:43:58Z

...che-core-api-debug-shared/src/main/java/org/eclipse/che/api/debug/shared/model/Location.java

@@ -29,4 +31,11 @@

  /** Returns project path, for resource which we are debugging now. */
  String getResourceProjectPath();
+
+  /** Returns the method is being executed. */
+  @Nullable


Add a comment when this method returns null please

Hard to predict.

mmorhun · 2017-08-22T11:44:46Z

...re-api-debug-shared/src/main/java/org/eclipse/che/api/debug/shared/model/StackFrameDump.java

@@ -19,4 +20,8 @@

  /** The list of local variables. */
  List<? extends Variable> getVariables();
+
+  /** Returns location of the frame. */
+  @Nullable


Add a comment when this method returns null please

codenvy-ci · 2017-08-23T17:17:17Z

Build # 3510 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3510/ to view the results.

codenvy-ci · 2017-09-11T14:10:24Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3627/

codenvy-ci · 2017-09-12T10:09:55Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3638/

codenvy-ci · 2017-09-13T08:34:02Z

Build # 3650 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3650/ to view the results.

tolusha · 2017-09-13T09:21:21Z

ci-build

tolusha · 2017-09-13T10:07:00Z

codenvy-ci · 2017-09-13T10:23:24Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3655/

CHE-3708: Thread dump for java debugger

Anatoliy Bazko added 7 commits January 16, 2017 13:03

CHE-3708: Rename method getValue -> getString

e79881a

CHE-3708: Variable.getValue() returns instance of SimpleValue instead…

26a1c72

… of String

CHE-3708: Remove Variable.getVariables() method

65c4033

Jdi classes implements model interfaces

3c35fce

Remove Variable.existsInformation method

3989395

Introduce ThreadDump data model

c91483c

JDB threaddumps

7bb0d14

tolusha added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. labels Jun 9, 2017

tolusha self-assigned this Jun 9, 2017

Merge master

36cab02

tolusha force-pushed the CHE-3708 branch from 1413875 to 36cab02 Compare June 9, 2017 12:19

Fix up

42479fb

Fix tests

2a19dd9

tolusha added 2 commits June 16, 2017 11:01

Merge remote-tracking branch 'origin/master' into CHE-3708

306afc7

Refactoring

27a5a65

Refactoring

7ec32bb

tolusha added 2 commits June 19, 2017 15:36

Refactoring

efe4afb

Merge remote-tracking branch 'origin/master' into CHE-3708

9581075

StackFrameDump

a93b45b

olexii4 and others added 3 commits June 21, 2017 10:21

CHE-4518: change styles for input boxes

f98829e

Signed-off-by: Oleksii Orel <oorel@redhat.com>

moved showIDE logic into the routeChange listener

1a1166e

Signed-off-by: Oleksii Orel <oorel@redhat.com>

CHE-5390: Fix bug when failed to commit renamed files (#5394)

8d46461

AndrienkoAleksandr approved these changes Aug 22, 2017

View reviewed changes

mmorhun reviewed Aug 22, 2017

View reviewed changes

vparfonov approved these changes Aug 22, 2017

View reviewed changes

tolusha added 3 commits August 23, 2017 16:23

Refactoring

2d33bd9

Rename ThreadDump model class to ThreadState

63b3f87

Fix up

7bbc09c

tolusha added 6 commits September 6, 2017 13:52

Refactoring

1c2d4ab

Fix up

ed918da

Merge remote-tracking branch 'origin/master' into CHE-3708

f0a96cc

Fix up

f36d607

Fix tests

11fabb0

Merge remote-tracking branch 'origin/master' into CHE-3708

01fe41c

mmorhun approved these changes Sep 11, 2017

View reviewed changes

Add selenium test

aa30693

tolusha requested review from ashumilova and benoitf as code owners September 12, 2017 08:38

Merge remote-tracking branch 'origin/master' into CHE-3708

0eaacfc

Fix up

89c264e

Fix up

08ab0c7

tolusha merged commit 6b76cad into master Sep 13, 2017

tolusha deleted the CHE-3708 branch September 13, 2017 10:35

skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020

Thread dump for java debugger (#5320)

24d0fd9

CHE-3708: Thread dump for java debugger

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Thread dump for java debugger #5320

Thread dump for java debugger #5320

tolusha commented Jun 9, 2017 •

edited

Loading

codenvy-ci commented Jun 9, 2017

codenvy-ci commented Jun 14, 2017

codenvy-ci commented Jun 15, 2017

codenvy-ci commented Jun 16, 2017

codenvy-ci commented Jun 19, 2017

codenvy-ci commented Jun 19, 2017

codenvy-ci commented Jun 19, 2017

mmorhun Aug 22, 2017

mmorhun Aug 22, 2017

mmorhun Aug 22, 2017

mmorhun Aug 22, 2017

mmorhun Aug 22, 2017

mmorhun Aug 22, 2017

tolusha Aug 23, 2017

mmorhun Aug 22, 2017

tolusha Aug 23, 2017

mmorhun Aug 22, 2017

tolusha Aug 23, 2017

mmorhun Aug 22, 2017

tolusha Aug 23, 2017

mmorhun Sep 4, 2017 •

edited

Loading

mmorhun Aug 22, 2017

tolusha Aug 23, 2017

mmorhun Aug 22, 2017

codenvy-ci commented Aug 23, 2017

codenvy-ci commented Sep 11, 2017

codenvy-ci commented Sep 12, 2017

codenvy-ci commented Sep 13, 2017

tolusha commented Sep 13, 2017

tolusha commented Sep 13, 2017

codenvy-ci commented Sep 13, 2017

Thread dump for java debugger #5320

Thread dump for java debugger #5320

Conversation

tolusha commented Jun 9, 2017 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

codenvy-ci commented Jun 9, 2017

codenvy-ci commented Jun 14, 2017

codenvy-ci commented Jun 15, 2017

codenvy-ci commented Jun 16, 2017

codenvy-ci commented Jun 19, 2017

codenvy-ci commented Jun 19, 2017

codenvy-ci commented Jun 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmorhun Sep 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenvy-ci commented Aug 23, 2017

codenvy-ci commented Sep 11, 2017

codenvy-ci commented Sep 12, 2017

codenvy-ci commented Sep 13, 2017

tolusha commented Sep 13, 2017

tolusha commented Sep 13, 2017

codenvy-ci commented Sep 13, 2017

tolusha commented Jun 9, 2017 •

edited

Loading

mmorhun Sep 4, 2017 •

edited

Loading