Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silky smooth factory workflow #536

Merged
merged 3 commits into from
Feb 26, 2016
Merged

Silky smooth factory workflow #536

merged 3 commits into from
Feb 26, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 26, 2016

No description provided.

@mshaposhnik
Copy link
Contributor

It's a part of moving factory acceptance to the dashb ?
So the perUser/perClick/perAccount policies will be managed in other place ?

@benoitf
Copy link
Contributor Author

benoitf commented Feb 26, 2016

yes
https://github.com/codenvy/dashboard/blob/master/src/app/factories/load-factory/load-factory.controller.js#L80-L95

@mshaposhnik
Copy link
Contributor

ok

@skabashnyuk
Copy link
Contributor

@vparfonov ?

@vparfonov
Copy link
Contributor

ok

1 similar comment
@skabashnyuk
Copy link
Contributor

ok

@benoitf
CODENVY-132 FactoryWorkspaceComponent is reusing a previously created…
6aad4e3 
… workspace

Change-Id: I4d3d4cd9693b1443d4aeebd9148a9668679681bb
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf
CHE-602 allow to send to ide new parameters
d097731 
Change-Id: I0a10ca6a2ad403349a87ba80b124918eca7bff11
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf
CHE-603 allow to plug new route
660d58d 
Change-Id: Iac866c734f71f35d405cced67feccb756ea44cea
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf benoitf merged commit 660d58d into master Feb 26, 2016
@benoitf benoitf deleted the CODENVY-132 branch March 3, 2016 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benoitf @mshaposhnik @skabashnyuk @vparfonov