Add support for using multiple language servers to be registered for the same files #4609 #5442

tsmaeder · 2017-06-22T13:47:39Z

What does this PR do?

This PR allows starting multiple language servers per file. The results for various calls are merged according to https://code.visualstudio.com/docs/extensionAPI/vscode-api.
Opening an editor blocks until all necessary editors have started. The merged server capabilities for all the applicable servers are computed whenever an editor is opened. One copy of a language server is started per project.

This PR is based on #5156, which is not merged yet.

What issues does this PR fix or reference?

#4609

Changelog

Added support for using multiple language servers to be registered for the same files.

Release Notes

The support of the Language Server Protocol is getting better and better in Eclipse Che. Two main aspects have been improved: the ability to register a language server for a specific filename and the ability to support multiple language servers for a single file.

Until now, it was only possible to register a language server for a file extension like *.xml, but now it is possible to register a language server for a specific filename like pom.xml. The improvements also allow for multiple extensions/or and filenames to be mapped to a single mime type and language id. The language registration and language server launcher registration have also been separated. You can learn more into the following documentation.

This version also allows multiple language servers to be used for a single file. When opening a file in an editor, the language servers registered for that file are initialized and started if needed. The results coming from the various language servers are computed together.

You can see a sample demo here in a python file, where Python language server and another demo language server are both registered and working together.

Those fundamental improvements on how language servers are supported in Che are going to provide more flexibility for contributors and more capabilities for users. As an example, it is now possible to provide support for a pom.xml file, where a Maven language server and an XML language server are both registered and operating together.

Docs PR

eclipse-che/che-docs#256

codenvy-ci · 2017-06-22T13:49:01Z

Can one of the admins verify this patch?

dkuleshov · 2017-06-27T12:04:53Z

...ore-ide-api/src/main/java/org/eclipse/che/ide/api/editor/annotation/AnnotationModelImpl.java

@@ -70,6 +71,7 @@ protected void addAnnotation(final Annotation annotation, final Position positio
        try {
            addPosition(position);
        } catch (BadLocationException ignore) {
+            Log.error(getClass(), "BadLocation for "+annotation);


If I'm not mistaken this line is not properly formatted

vparfonov · 2017-06-27T12:15:25Z

...pse/che/plugin/languageserver/ide/editor/quickassist/LanguageServerQuickAssistProcessor.java

@@ -12,7 +12,7 @@

 import com.google.gwt.user.client.rpc.AsyncCallback;
 import com.google.gwt.user.client.ui.Widget;
-
+import org.eclipse.che.api.languageserver.shared.dto.DtoClientImpls.CodeActionParamsDto;


Why you use here implementations instead of interfaces?

lsp4j does not use interfaces

evidolob · 2017-06-27T12:25:11Z

...-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/editor/DiagnosticCollector.java

@@ -22,18 +22,18 @@
     * @param diagnostic
     *         Diagnostic - The discovered diagnostic.
     */
-    void acceptDiagnostic(Diagnostic diagnostic);
+    void acceptDiagnostic(String diagnosticsCollection, Diagnostic diagnostic);


Can you add description what diagnosticsCollection parameter mean

yes, not clear

slemeur · 2017-06-27T16:44:04Z

Nice @tsmaeder !

This is really good, we need to write a nice release note paragraph for that enhancement!
I think that we should record a small demo for that. Would you be able to record an animated gif? It would perfectly illustrate the use case and the new capability.

I'll provide the release note summary.

Thanks

slemeur · 2017-07-03T08:38:29Z

Hi @tsmaeder. Could you record a small animated gif that we will include in the release note to demo the new capability? (Don't forget to zoom-in on your browser so that it will be visible to the reader);

Thanks in advance

tsmaeder · 2017-07-05T14:24:27Z

@benoitf this change should not be visible to the user until we start USING multiple language servers/file. Does it make sense to put it in the release notes?

benoitf · 2017-07-05T14:30:09Z

@tsmaeder are you sure the question is for me or it's for @slemeur asking for a gif demo ?

slemeur · 2017-07-05T14:48:52Z

@tsmaeder : This issue + #5156 are adding new capability to the system - and they are pretty excellent ! I'll handle the release note section but its goal will not be on the end-user benefits, it will focus on explaining the new capability added to the system and what it will allow to do in the future - this could be interesting for any Che contributors.

When we will leverage the capability, like pom.xml file for example, we will focus the explanations on the what kind of features the user will get.

The animated gif might not be necessary, but as you did a demo during the sprint demo, I thought it could nicely illustrate the explanations.

tsmaeder · 2017-07-07T12:06:35Z

tsmaeder · 2017-07-07T12:06:58Z

Longer demo video available here: https://youtu.be/-G3WlGskIvs

Signed-off-by: Thomas Mäder <tmader@redhat.com>

slemeur · 2017-07-07T12:27:06Z

Thanks a lot @tsmaeder !

slemeur

👍

Signed-off-by: Thomas Mäder <tmader@redhat.com>

benoitf · 2017-07-10T08:19:13Z

ci-build

…the same files eclipse-che#4609 (eclipse-che#5442) Add support for using multiple language servers for the same files. Signed-off-by: Thomas Mäder <tmader@redhat.com>

tsmaeder changed the title ~~WIP: 4609 multiple ls~~ 4609 multiple ls Jun 27, 2017

dkuleshov reviewed Jun 27, 2017

View reviewed changes

slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 27, 2017

vparfonov reviewed Jun 27, 2017

View reviewed changes

evidolob reviewed Jun 27, 2017

View reviewed changes

slemeur self-requested a review June 27, 2017 16:44

benoitf changed the title ~~4609 multiple ls~~ Added support for using multiple language servers to be registered for the same files #4609 Jun 29, 2017

benoitf changed the title ~~Added support for using multiple language servers to be registered for the same files #4609~~ Add support for using multiple language servers to be registered for the same files #4609 Jun 29, 2017

tsmaeder force-pushed the 4609_multiple_LS branch from 2fd6fe0 to c283fbe Compare July 2, 2017 12:48

benoitf assigned tsmaeder Jul 4, 2017

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/californication labels Jul 4, 2017

tsmaeder force-pushed the 4609_multiple_LS branch from c283fbe to 18067e6 Compare July 4, 2017 15:01

tsmaeder force-pushed the 4609_multiple_LS branch from dd9de00 to 0193958 Compare July 6, 2017 06:45

vparfonov approved these changes Jul 6, 2017

View reviewed changes

tsmaeder added 7 commits July 7, 2017 14:08

Register languages by file name

c5490bc

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Remove bogus binding.

4a5d112

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Formatting changes

99070cb

Signed-off-by: Thomas Mäder <tmader@redhat.com>

First cut of multiple language servers

9b2cc93

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fix csharp LS

a24eb51

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fixed build & tests

43af8cc

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fix initialization bugs

cce5c1e

Signed-off-by: Thomas Mäder <tmader@redhat.com>

tsmaeder added 12 commits July 7, 2017 14:15

Post rebase fixes.

86850a1

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Binding receivers

846fdb1

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Various bugfixes.

48401d3

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Add id field to initialized server

b82faa2

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fix lsp implementation

ff264b2

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fixes to code actions & content assist

a9ed87e

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fix license check.

1971eb4

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Implement completion item resolution for multiple LS

0677d96

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Formatting & fix document highlight processing

21ddf19

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Support for showing diagnostics from multiple language servers

c2fd20a

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Handle case of LS launchers not ready or failing.

fdba7ca

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Address PR comments

f8f459f

Signed-off-by: Thomas Mäder <tmader@redhat.com>

tsmaeder force-pushed the 4609_multiple_LS branch from 0193958 to f8f459f Compare July 7, 2017 12:45

slemeur approved these changes Jul 7, 2017

View reviewed changes

tsmaeder mentioned this pull request Jul 7, 2017

Updated devdoc for multi-ls suport eclipse-che/che-docs#256

Merged

Renamed variable, improved doc.

ad5c622

Signed-off-by: Thomas Mäder <tmader@redhat.com>

evidolob approved these changes Jul 7, 2017

View reviewed changes

dkuleshov approved these changes Jul 10, 2017

View reviewed changes

tsmaeder merged commit 9f88048 into eclipse-che:master Jul 10, 2017

tsmaeder removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 10, 2017

tsmaeder added this to the 5.15.0 milestone Jul 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for using multiple language servers to be registered for the same files #4609 #5442

Add support for using multiple language servers to be registered for the same files #4609 #5442

tsmaeder commented Jun 22, 2017 •

edited

Loading

codenvy-ci commented Jun 22, 2017

dkuleshov Jun 27, 2017

vparfonov Jun 27, 2017

tsmaeder Jul 5, 2017

evidolob Jun 27, 2017

tsmaeder Jul 5, 2017

slemeur commented Jun 27, 2017

slemeur commented Jul 3, 2017

tsmaeder commented Jul 5, 2017

benoitf commented Jul 5, 2017

slemeur commented Jul 5, 2017

tsmaeder commented Jul 7, 2017 •

edited

Loading

tsmaeder commented Jul 7, 2017

slemeur commented Jul 7, 2017

slemeur left a comment

benoitf commented Jul 10, 2017

Add support for using multiple language servers to be registered for the same files #4609 #5442

Add support for using multiple language servers to be registered for the same files #4609 #5442

Conversation

tsmaeder commented Jun 22, 2017 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

Docs PR

codenvy-ci commented Jun 22, 2017

dkuleshov Jun 27, 2017

Choose a reason for hiding this comment

vparfonov Jun 27, 2017

Choose a reason for hiding this comment

tsmaeder Jul 5, 2017

Choose a reason for hiding this comment

evidolob Jun 27, 2017

Choose a reason for hiding this comment

tsmaeder Jul 5, 2017

Choose a reason for hiding this comment

slemeur commented Jun 27, 2017

slemeur commented Jul 3, 2017

tsmaeder commented Jul 5, 2017

benoitf commented Jul 5, 2017

slemeur commented Jul 5, 2017

tsmaeder commented Jul 7, 2017 • edited Loading

tsmaeder commented Jul 7, 2017

slemeur commented Jul 7, 2017

slemeur left a comment

Choose a reason for hiding this comment

benoitf commented Jul 10, 2017

tsmaeder commented Jun 22, 2017 •

edited

Loading

tsmaeder commented Jul 7, 2017 •

edited

Loading