Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework workspace detail flow #5451

Merged
merged 21 commits into from
Sep 13, 2017
Merged

Rework workspace detail flow #5451

merged 21 commits into from
Sep 13, 2017

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 23, 2017 •
edited by slemeur
Loading

What does this PR do?

Improve workspace details toolbar and panels.

What issues does this PR fix or reference?

#5258
#5257
#5259
#5458
#5460
#5700
#5701

Changelog

-- Improve workspace details toolbar.
-- Restyle main tab panels.

Release Notes

This version introduces a major usability improvement on the dashboard. In the latest versions of Che, we focused on providing a new flow to create workspaces. Now, we are introducing a new way of managing your workspace and configuring it.

We splited the configuration of a workspace into new sections:

  • Overview: Define the main workspace information
  • Projects: Manage the projects from your workspace
  • Machines: Define the runtime used by the workspace
  • Agents: Configure the tools that you want to install the workspace
  • Servers: Access services that are running in your workspace and expose their ports
  • Env Variable: Define the environment variable for the workspace
  • Config: Get the json configuration of the workspace
  • SSH: Connect to your workspace over SSH

[Insert Machine gif]

You can easily manage the machines of your workspace. You can define multiple machines, by using a recipe (dockerfile or composfile). You can easily define which of the machine must be used as dev-machine which will get the projects mounted in. Also, it is simpler to configure the RAM for each of the machines of your workspace.

[Insert Agent gif]

Configuring the tools that are injected into each of the machine you are using in your workspace is now getting simpler. The dedicated tab, allow you to select a machine and just toggle on/off each of the Agents you want to enable or disable.

[Insert Servers gif]

Easily get information about the services that are running in your workspace (when the workspace is running). You can also expose new services which can be used by external ports.

[Insert Env Variables gif]

In certain situation, you might need to configure certain environment variables for your machine. This can be done as part of the machine's recipe, but we are now making it simpler, by providing the ability to manage that directly from the dashboard.

We are looking forward to hearing your feedback on this important improvements on the way you can manage and configure your workspaces.

@slemeur
Copy link
Contributor

slemeur commented Jun 23, 2017

Few feedbacks @olexii4

In the Config tab:

  • replace "Workspace Config" by "Workspace"

It seems that the white line is a bit too wide compared to the text it must highlight. Would you be able to reduce the width?

This PR is not handling the workspace status indicator in the top navigation bar - am I correct?

@ashumilova
Copy link
Contributor

@olexii4 are selenium tests affected by this PR?

@slemeur slemeur requested a review from benoitf June 23, 2017 12:55
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2904/

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 23, 2017

@slemeur This toolbar indicator in PR is handling the workspace status
ezgif com-video-to-gif 1

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 23, 2017

selection_042

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 23, 2017

done

@slemeur
Copy link
Contributor

slemeur commented Jun 23, 2017

OK. the status widget was a little restyle in the mockup.
screen shot 2017-06-23 at 16 35 27

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2907/

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 26, 2017

https://github.com/codenvy/qa/pull/990

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 26, 2017

selection_044

@codenvy-ci
Copy link

Build # 3034 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3034/ to view the results.

@codenvy-ci
Copy link

Build # 3046 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3046/ to view the results.

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3059/

@olexii4
Copy link
Contributor Author

olexii4 commented Jul 17, 2017 •
edited
Loading

selection_004

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3083/

@codenvy-ci
Copy link

Build # 3099 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3099/ to view the results.

@slemeur
Copy link
Contributor

slemeur commented Jul 19, 2017

Reviews:

1- The loading behaviour is not nice. I can see the empty form and then content added into the form. It looks like flickering - we should display a loader while we are getting the information.

workspace-details-loading

2- Workspace details:
screen_shot_2017-07-19_at_10_14_22

3- Workspace machines:
screen_shot_2017-07-19_at_10_22_29

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3135/

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3190/

@olexii4 olexii4 changed the title CHE 5258 Improve workspace details toolbar [WIP] CHE 5258 Improve workspace details toolbar Jul 27, 2017
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3198/

olexii4 and others added 17 commits September 12, 2017 12:08
@olexii4
CHE-5458 redesign workspace overview page
d5d8c84 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
CHE-5460 create widget for button with menu
c7dfe96 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
code cleanup
351956f 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
improve test for workspace status button
3295a67 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
add Env Variable and Server pages to workspace details
6c8b393 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
improve workspace-status-button widget
aa697e7 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
CHE-5459 add workspace agents page
a28dbe1 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
fixup! add Env Variable and Server pages to workspace details
b306e9e
@olexii4
improve workspace-detail page
21208f3 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@akurinnoy @olexii4
CHE-5713: Re-use projects section from workspace creation in workspac…
fcd9e04 
…e details (#5977)

* CHE-5713: add che-list-header-additional-parts component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: refactor project-source-selector component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: add add-project-popover component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: add che-multi-transclude directive

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: add che-toggle-popover component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: re-use of Projects section on Workspace Details page.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! CHE-5713: re-use of Projects section on Workspace Details page.

* fixes

- for controllers import-blank-project, import-git-project,
   import-github-project, import-zip-project, template-selector:
   unsubscribe actions on $destroy event;
- fix che-multi-transclude directive,
   add che-multi-transclude-part directive;
- fix che-number-spinner directive;
- fix che-toggle-popover directive;

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@olexii4
improve flow for workspace detail
9c9e80a 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Change copyright owner to "Red Hat, Inc" on remaining files
8615a37 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
improve styles for environment widgets
7e72748 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
add warning message with a page link about an error
9cbfd71 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
fix failed tests
cc7d88d 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
improve Add project flow
9b7bc50 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
improve workspace status button
a725c3d 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3641/

@olexii4
CODENVY-2409 fix che-input widget
ef65535 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 merged commit 8040081 into master Sep 13, 2017
@olexii4 olexii4 deleted the CHE-5258 branch September 13, 2017 16:06
@dmytro-ndp dmytro-ndp mentioned this pull request Sep 13, 2017
Merged
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3668/

@slemeur slemeur mentioned this pull request Sep 18, 2017
Closed
@SkorikSergey SkorikSergey mentioned this pull request Oct 12, 2017
Closed
@SkorikSergey SkorikSergey mentioned this pull request Nov 27, 2017
Merged
@SkorikSergey SkorikSergey mentioned this pull request Dec 7, 2017
Merged
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@olexii4
Rework workspace detail flow (#5451)
75e9f18 
* CHE-5258: improve workspace details toolbar

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* CHE-5257: rework main tab panels in dashboard

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* CHE-5259: add machine page to workspace details

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* CHE-5458 redesign workspace overview page

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* CHE-5460 create widget for button with menu

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* code cleanup

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* improve test for workspace status button

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* add Env Variable and Server pages to workspace details

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* improve workspace-status-button widget

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* CHE-5459 add workspace agents page

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* fixup! add Env Variable and Server pages to workspace details

* improve workspace-detail page

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* CHE-5713: Re-use projects section from workspace creation in workspace details (#5977)

* CHE-5713: add che-list-header-additional-parts component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: refactor project-source-selector component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: add add-project-popover component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: add che-multi-transclude directive

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: add che-toggle-popover component

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-5713: re-use of Projects section on Workspace Details page.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! CHE-5713: re-use of Projects section on Workspace Details page.

* fixes

- for controllers import-blank-project, import-git-project,
   import-github-project, import-zip-project, template-selector:
   unsubscribe actions on $destroy event;
- fix che-multi-transclude directive,
   add che-multi-transclude-part directive;
- fix che-number-spinner directive;
- fix che-toggle-popover directive;

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* improve flow for workspace detail

* Change copyright owner to "Red Hat, Inc" on remaining files

* improve  styles for environment widgets

* add warning message with a page link about an error

* fix failed tests

* improve Add project flow

* improve workspace status button

* CODENVY-2409 fix che-input widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@ashumilova ashumilova ashumilova approved these changes

@slemeur slemeur slemeur approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
5.18.0
Development

Successfully merging this pull request may close these issues.
7 participants
@olexii4 @slemeur @ashumilova @codenvy-ci @SkorikSergey @benoitf @akurinnoy