Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin runtime stack #5520

Merged
3 commits merged into from
Jul 6, 2017
Merged

Add Kotlin runtime stack #5520

3 commits merged into from
Jul 6, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 3, 2017

Description

An Kotlin based stack is now available in stack library for Che.

Changelog

New Kotlin stack offers Kotlin CLI - version 1.1.3

A simple Hello World tutorial for Che docs will be provided a but later.

Release Note

kotlin_logo_wordmark-e1495140797136

We’ve added a new stack on Eclipse Che for Kotlin. You can now build Kotlin applications by easily creating a workspace from the Kotlin stack which is Ubuntu based  —  no configuration needed!

Refer to the following documentation to learn how to get the new stacks while upgrading your Eclipse Che.

Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
@ghost ghost requested a review from slemeur July 3, 2017 12:41
@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2017

where is the associated PR in eclipse/che-dockerfiles ?

@ghost
Copy link
Author

ghost commented Jul 3, 2017

eclipse-che/che-dockerfiles@5ddeabd Committed straight to master since those were build fixes.

@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2017

AFAIK all commits should use PR and Kotlin is not a build fix, it's a new stuff

@ghost
Copy link
Author

ghost commented Jul 3, 2017

We needed to fix the legal openjdk problem for stacks, so i had to rebuild all images today. Kotlin was a nice addition to that commit (there were questions about Kotlin support so I decided to an a runtime stack with it)

@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2017

I'm not arguing that Kotlin support was bad, only to follow the process of using pull requests.

@codenvy-ci
Copy link

benoitf
benoitf previously approved these changes Jul 3, 2017
@slemeur
Copy link
Contributor

slemeur commented Jul 3, 2017

A description + changelog should be added to the PR.

@benoitf
Copy link
Contributor

benoitf commented Jul 6, 2017

@eivantsov in the description there is "A simple Hello World tutorial for Che docs will be provided a but later."
IMHO it's bit instead of but

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jul 6, 2017
@codenvy-ci
Copy link

Build # 3004 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3004/ to view the results.

@ghost
Copy link
Author

ghost commented Jul 6, 2017

ci-build

@@ -2658,6 +2675,7 @@
}
},
"recipe": {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have a newline inserted there ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was resolving conflicts and this showed up :) Should be ok now

@benoitf benoitf dismissed their stale review July 6, 2017 11:47

commits after my initial review, dismiss

Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
@ghost ghost merged commit aff3be6 into master Jul 6, 2017
@ghost ghost deleted the kotlin_stack branch July 6, 2017 13:26
@codenvy-ci
Copy link

Build # 3010 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3010/ to view the results.

@slemeur
Copy link
Contributor

slemeur commented Jul 6, 2017

@eivantsov : Please assign a milestone when merging.

@slemeur slemeur removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 6, 2017
@slemeur slemeur added this to the 5.15.0 milestone Jul 6, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* Add Kotlin runtime stack

Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>

* Remove extra line

Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants