Move binding ServerIdleDetctor to the assembly module #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vparfonov
added
kind/task
garagatyi
approved these changes
Jul 5, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2998/ |
benoitf
reviewed
Jul 5, 2017
| import javax.inject.Inject; | ||
| import javax.inject.Named; | ||
| import javax.inject.Singleton; | ||
| import io.fabric8.kubernetes.api.model.Container; |
There was a problem hiding this comment.
all these formatting issues should be in another commit.
Because looking at the history, it will be non-sense if sorting of imports correspond to "move server idle detector"
sunix
reviewed
Jul 5, 2017
| import org.eclipse.che.api.core.model.workspace.Workspace; | ||
| import org.eclipse.che.api.core.notification.EventService; | ||
| import org.eclipse.che.api.workspace.server.event.ServerIdleEvent; |
There was a problem hiding this comment.
I guess package change for ServerIdleEvent is the only "real" change in this file ?
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
vparfonov
force-pushed
the
moveServerIdleDetector
branch
from
66681d5
to
d06ef69
Compare
benoitf
approved these changes
Jul 5, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3001/ |
|
@vparfonov : please assign milestone when merging. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Parfonov vparfonov@redhat.com
What does this PR do?