Adapt JUnit4 runner according new API #5710

svor · 2017-07-17T19:21:04Z

What does this PR do?

Added a base implementation of JUnit4 framework.
What was made:

Recognize JUnit4 test framework in a java file;
Run only one test method from the opened test class;
Run all test methods from the opened test class;
Annalize a test class and build the tree of tests before running;
Debug mod for running tests.

The simple demo:
https://youtu.be/fEM9dLDzRmo

What issues does this PR fix or reference?

#5473

Changelog

Run/Debug JUnit4 tests by using JUnit4 API
Build a tree of tests before running
Can run one test method or all tests from the test class

Release Notes

In this version we have been implementing JUnit4 API for running tests. We added default interfaces and mecanism which will allow to bring better test capabilities inside of Eclipse Che. We have also reworked the JUnit runner in order to use features:

Run one test method:

Run all tests from the test class:

Debug test:

codenvy-ci · 2017-07-17T20:18:01Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3084/

codenvy-ci · 2017-07-18T08:24:42Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3085/

davidfestal · 2017-07-18T08:41:25Z

...unit-server/src/main/java/org/eclipse/che/plugin/testing/junit/server/junit4/TestRunner.java

+        parameters.setJavaExecutable(JAVA_EXECUTABLE);
+        parameters.setMainClassName(MAIN_CLASS_NAME);
+
+        List<String> classPath = new ArrayList<>();


Several testing frameworks or test runners (such as arquillian, etc ...) assume that the current working directory should be the root directory of the project.
See this issue as an example.
So it seems that the working directory should be explicitly set to the root directory of the project being tested.
This would also be consistent with the way tests are run inside maven afaik.
This has already been done for the TestNG part ( see this discussion and this line ).

Miss to set a value of the working directory. Thank you!

codenvy-ci · 2017-07-18T10:43:29Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3087/

vparfonov · 2017-07-18T13:31:08Z

...ting-classpath/src/main/java/org/eclipse/che/plugin/java/testing/AbstractJavaTestRunner.java


-    private static final Logger LOG = LoggerFactory.getLogger(AbstractJavaTestRunner.class);
+    protected static final String PROJECTS_ROOT_FOLDER = "/projects";


Can we replace hrdcoded "/projects" with
@Named("che.user.workspaces.storage") File projectsRoot ?

We can. I've replaced

vparfonov · 2017-07-18T13:33:28Z

...e-plugin-testing-junit-runtime/src/main/java/org/eclipse/che/junit/TestingMessageHelper.java

+    public static void treeNode(PrintStream out, Description description) {
+        String location = description.getClassName() + "." + description.getMethodName();
+        out.println(create("suiteTreeNode",
+                           new Pair("name", escape(description.getMethodName())),


Maybe some constant here for "name", "location" and etc?

Moved to constants

vparfonov · 2017-07-18T13:35:37Z

...unit-server/src/main/java/org/eclipse/che/plugin/testing/junit/server/junit4/TestRunner.java

+/**
+ * JUnit implementation for the test runner service.
+ */
+public class TestRunner extends AbstractJavaTestRunner {


Rename to JUnit4TestRunner ?

codenvy-ci · 2017-07-19T10:21:18Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3104/

skabashnyuk · 2017-07-19T12:44:49Z

...erver/src/main/java/org/eclipse/che/plugin/testing/junit/server/junit4/JUnit4TestRunner.java

+    public List<TestResultDto> getTestResults(List<String> testResultsPath) {
+        throw new UnsupportedOperationException();
+    }
+}


skabashnyuk · 2017-07-19T12:45:11Z

...erver/src/main/java/org/eclipse/che/plugin/testing/junit/server/junit4/JUnit4TestRunner.java

+import java.util.Set;
+
+/**
+ * JUnit implementation for the test runner service.


Aren't you an author of this file?

I am. But we decided (inside our team) don't add an author to the javadoc.

slemeur · 2017-07-19T12:58:02Z

@svor 👍 . Few feedbacks:

When the tests are executed, there is no status displayed to the user to know the progress. Would it be possible to display progress information ?
Could you record few animated gif for the release note? I think we need to split your video between the new capabilities:
-- Can run one test method or all tests from the test class
-- Build a tree of tests before running
-- Debug test

codenvy-ci · 2017-07-19T14:20:46Z

Build # 3110 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3110/ to view the results.

svor · 2017-07-19T15:20:34Z

@slemeur I've updated the PR, please take a look

# Conflicts: # plugins/plugin-testing-java/plugin-testing-junit/che-plugin-testing-junit-ide/pom.xml # plugins/plugin-testing-java/plugin-testing-testng/che-plugin-testing-testng-ide/pom.xml

slemeur · 2017-07-19T15:43:57Z

thanks @svor !

codenvy-ci · 2017-07-19T17:35:08Z

Build # 3114 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3114/ to view the results.

codenvy-ci · 2017-07-19T21:03:01Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3117/

svor added 6 commits July 13, 2017 12:34

CHE-5473: first implementation for JUnit4 test runner

ae1d2d9

CHE-5473: move implementation of JUnit4 to the special package

959f5da

CHE-5473: add duration value to the message output

8011519

CHE-5473: build test tree before starting

ca2a4df

Merge branch 'master' into CHE-5473

539cfd2

CHE-5473: remove old test actions

3eab90d

svor added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels Jul 17, 2017

svor added this to the 5.15.0 milestone Jul 17, 2017

svor self-assigned this Jul 17, 2017

svor requested review from davidfestal, evidolob, vparfonov and slemeur July 17, 2017 19:21

svor requested review from riuvshin and skabashnyuk as code owners July 17, 2017 19:21

svor changed the title ~~Che 5473~~ Adopt JUnit4 runner according new API Jul 17, 2017

svor changed the title ~~Adopt JUnit4 runner according new API~~ Adapt JUnit4 runner according new API Jul 18, 2017

CHE-5473: clean pom

67c144b

davidfestal requested changes Jul 18, 2017

View reviewed changes

CHE-5473: set working directory

9739671

davidfestal approved these changes Jul 18, 2017

View reviewed changes

riuvshin modified the milestones: 5.15.0, 5.16.0 Jul 18, 2017

vparfonov reviewed Jul 18, 2017

View reviewed changes

ibuziuk mentioned this pull request Jul 18, 2017

[Rebase oscon] Verify that on master branch Unit Tests are started in their own process now (c.f. CHE-214) redhat-developer/rh-che#153

Closed

CHE-5473: code cleanup

51d2444

Merge branch 'master' into CHE-5473

bdcefad

vparfonov approved these changes Jul 19, 2017

View reviewed changes

skabashnyuk approved these changes Jul 19, 2017

View reviewed changes

evidolob approved these changes Jul 19, 2017

View reviewed changes

CHE-5473: add new line

e65ca5e

CHE-5473: add icons for test presentation

3599210

Merge branch 'master' into CHE-5473

cb632b0

# Conflicts: # plugins/plugin-testing-java/plugin-testing-junit/che-plugin-testing-junit-ide/pom.xml # plugins/plugin-testing-java/plugin-testing-testng/che-plugin-testing-testng-ide/pom.xml

riuvshin approved these changes Jul 19, 2017

View reviewed changes

fix build

bcd1c13

vparfonov approved these changes Jul 20, 2017

View reviewed changes

svor merged commit 6c6e00e into master Jul 20, 2017

svor deleted the CHE-5473 branch July 20, 2017 06:49

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017

Adapt JUnit4 runner according new API (eclipse-che#5710)

aae5e57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapt JUnit4 runner according new API #5710

Adapt JUnit4 runner according new API #5710

svor commented Jul 17, 2017 •

edited

Loading

codenvy-ci commented Jul 17, 2017

codenvy-ci commented Jul 18, 2017

davidfestal Jul 18, 2017

svor Jul 18, 2017

codenvy-ci commented Jul 18, 2017

vparfonov Jul 18, 2017

svor Jul 19, 2017

vparfonov Jul 18, 2017

svor Jul 19, 2017

vparfonov Jul 18, 2017

svor Jul 19, 2017

codenvy-ci commented Jul 19, 2017

skabashnyuk Jul 19, 2017

svor Jul 19, 2017

skabashnyuk Jul 19, 2017

svor Jul 19, 2017

slemeur commented Jul 19, 2017

codenvy-ci commented Jul 19, 2017

svor commented Jul 19, 2017 •

edited

Loading

slemeur commented Jul 19, 2017

codenvy-ci commented Jul 19, 2017

codenvy-ci commented Jul 19, 2017


		private static final Logger LOG = LoggerFactory.getLogger(AbstractJavaTestRunner.class);
		protected static final String PROJECTS_ROOT_FOLDER = "/projects";

Adapt JUnit4 runner according new API #5710

Adapt JUnit4 runner according new API #5710

Conversation

svor commented Jul 17, 2017 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

codenvy-ci commented Jul 17, 2017

codenvy-ci commented Jul 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenvy-ci commented Jul 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenvy-ci commented Jul 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slemeur commented Jul 19, 2017

codenvy-ci commented Jul 19, 2017

svor commented Jul 19, 2017 • edited Loading

slemeur commented Jul 19, 2017

codenvy-ci commented Jul 19, 2017

codenvy-ci commented Jul 19, 2017

svor commented Jul 17, 2017 •

edited

Loading

svor commented Jul 19, 2017 •

edited

Loading