Move activity components to plugin-activity #5896
Conversation
mkuznyetsov
requested review from
benoitf,
evidolob,
garagatyi,
riuvshin,
skabashnyuk and
vparfonov
as code owners
| @@ -11,17 +11,23 @@ | |||
| Codenvy, S.A. - initial API and implementation | |||
|
|
|||
| --> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | |||
There was a problem hiding this comment.
is there a reason why the xsd has been renamed ?
There was a problem hiding this comment.
It seems that we have numerous usages of both URLs in different POMs throughout entire Che project for some reason.
And this happened because I was creating this pom by copying from another, which has this different url. I can revert it, but it seems it doesn't matter much, as http://maven.apache.org/maven-v4_0_0.xsd simply redirects to http://maven.apache.org/xsd/maven-4.0.0.xsd
Then one can normalize all poms to use same xsd URL across the project later (as a separate task) if needed.
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3273/ |
| <public path="public"/> | ||
|
|
||
| <source path="ide"/> | ||
| </module> |
| @@ -0,0 +1,24 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
I think we don't need this module only for one class with one const
| } | ||
|
|
||
| private native void init(String restContext, String wsId) /*-{ | ||
| $wnd.ActivityTracker.init(restContext, wsId); |
There was a problem hiding this comment.
yes, that's how native javascript is written in GWT code
There was a problem hiding this comment.
Oh, sorry, I missed that it was a native code
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3293/ |
dockerfiles/init/manifests/che.env
Outdated
| # Workspace Idle timeout | ||
| # The length of time after which workspaces will be automatically stopped, if no activity | ||
| # has been detected on them. Currently, keyboard and mouse interactions in IDE, as well as HTTP | ||
| # requests to ws-agent count as activity. Set "0" to disable automatic stop of inactive workspaces |
There was a problem hiding this comment.
please describe default value
…ctivity Conflicts: plugins/plugin-activity/che-plugin-activity-server/pom.xml
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3324/ |
ghost
mentioned this pull request
Move activity components to plugin-activity
slemeur
added
the
kind/task
What does this PR do?
Move all workspace activity related code to new plugin-activity:
Also enable activity tracking with keyboard + mouse in IDE
Add workspace inactive timeout variable to che.env
What issues does this PR fix or reference?
Changelog
Moved all workspace activity related code to new plugin-activity.
Fixed activity tracking with keyboard + mouse in IDE
Added workspace inactive timeout variable to che.env
Release Notes
Docs PR