Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-388 Don't use ugly browser prompt box to display 'Go to line' dialog window #595

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

vitaliy-guliy
Copy link
Contributor

Signed-off-by: Vitaliy Guliy vguliy@codenvy.com


line = model.getLineAtOffset(editor.getCaretOffset());

// try to use promptIDE(title, text, defaultValue, callback) function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these changes in built-codeEdit-amd.js will be lost after updating Orion editor to the next version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same we have with styles. They could be outdated after updating the editor.

…log window

Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
@vparfonov
Copy link
Contributor

ok

vitaliy-guliy pushed a commit that referenced this pull request Mar 1, 2016
CHE-388 Don't use ugly browser prompt box to display 'Go to line' dialog window
@vitaliy-guliy vitaliy-guliy merged commit a00c552 into master Mar 1, 2016
@vitaliy-guliy vitaliy-guliy deleted the CHE-388 branch March 1, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants