5485 apply workspace edit #5955

tsmaeder · 2017-08-09T13:10:29Z

What does this PR do?

Adds a "ApplyWorkspaceEditAction" that applies a LSP WorkspaceEdit to many files both open in and editor or not.

What issues does this PR fix or reference?

#5485

Changelog

Added "ApplyWorkspaceEditAction" to allow LSP code actions to edit multiple files at once.

Release Notes

Added "ApplyWorkspaceEditAction" to allow LSP code actions to edit multiple files at once.

Docs PR

eclipse-che/che-docs#271

codenvy-ci · 2017-08-09T13:11:01Z

Can one of the admins verify this patch?

codenvy-ci · 2017-08-09T13:14:01Z

Can one of the admins verify this patch?

benoitf · 2017-08-09T13:18:59Z

ci-build

codenvy-ci · 2017-08-09T14:09:07Z

Build # 3322 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3322/ to view the results.

benoitf · 2017-08-09T14:12:50Z

@tsmaeder build is failing with

[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/test/java/org/eclipse/che/api/languageserver/shared/util/StringStreamEditor.java
[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/test/java/org/eclipse/che/api/languageserver/shared/util/StreamEditorTest.java
[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/CharSource.java
[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/CharSink.java
[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/PositionComparator.java
[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/RangeComparator.java
[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/CharStreamEditor.java
[WARNING] Missing header in: /home/codenvy/workspace/che-pullrequests-build/wsagent/che-core-api-languageserver-shared/src/main/java/org/eclipse/che/api/languageserver/shared/model/FileEditParams.java

RomanNikitenko · 2017-08-09T14:33:20Z

...core-api-project/src/main/java/org/eclipse/che/api/vfs/impl/file/LocalVirtualFileSystem.java


+    private File createTempIoFile(VirtualFile parent, String prefix, String suffix) throws IOException {


You don't use parameters prefix and suffix - may be makes sense to remove them.

benoitf · 2017-08-16T07:39:13Z

ci-build

codenvy-ci · 2017-08-16T11:52:28Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3403/

vparfonov · 2017-08-17T11:50:44Z

...er-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/CharStreamEditor.java

+
+	private void writeAndCount(int ch, Consumer<Integer> dest) {
+		dest.accept(ch);
+		if (ch == '\r') {


Can we avoid empty block?

vparfonov · 2017-08-17T11:51:27Z

...er-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/CharStreamEditor.java

+    	return new Supplier<Integer>() {
+    		@Override
+    		public Integer get() {
+    			try {


formatting issue

vparfonov

basically ok for me, except a lot of formatting issues

vparfonov · 2017-08-17T11:51:44Z

...er-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/CharStreamEditor.java

+    		@Override
+    		public void accept(Integer ch) {
+    			try {
+    				w.write(ch);


formatting issue

vparfonov · 2017-08-17T11:51:57Z

...er-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/CharStreamEditor.java

+    	};
+    }
+
+}


vparfonov · 2017-08-17T11:52:22Z

...-shared/src/main/java/org/eclipse/che/api/languageserver/shared/util/PositionComparator.java

+public class PositionComparator implements Comparator<Position> {
+
+	@Override
+	public int compare(Position o1, Position o2) {


formatting issue

vparfonov · 2017-08-22T09:38:28Z

@tsmaeder When do you plan merge it?

tsmaeder · 2017-09-06T07:34:41Z

@vparfonov I was asking on the Eclipse Che Mattermost if we need additional review, since I've done some small changes.
Otherwise as soon as I've rebased it (again ;-))

Signed-off-by: Thomas Mäder <tmader@redhat.com>

benoitf · 2017-09-06T14:45:51Z

ci-build

vparfonov

Thanks, we will run nightly test with your branch

codenvy-ci · 2017-09-06T15:53:06Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3564/

slemeur · 2017-09-07T07:57:41Z

@vparfonov : As a maintainer, you have to ensure the PRs are merged with appropriate labels and milestone. Thanks

tsmaeder requested review from dkuleshov, evidolob and vparfonov as code owners August 9, 2017 13:10

tsmaeder force-pushed the 5485_apply_workspace_edit branch from 0bb0b3c to e9826c3 Compare August 9, 2017 13:18

dkuleshov requested a review from RomanNikitenko August 9, 2017 13:29

dkuleshov approved these changes Aug 9, 2017

View reviewed changes

tsmaeder mentioned this pull request Aug 9, 2017

Add mention of ApplyWorkspaceEditAction eclipse-che/che-docs#271

Merged

RomanNikitenko reviewed Aug 9, 2017

View reviewed changes

RomanNikitenko approved these changes Aug 9, 2017

View reviewed changes

tsmaeder force-pushed the 5485_apply_workspace_edit branch from e9826c3 to 2ddb668 Compare August 11, 2017 09:39

evidolob approved these changes Aug 16, 2017

View reviewed changes

vparfonov reviewed Aug 17, 2017

View reviewed changes

vparfonov approved these changes Aug 22, 2017

View reviewed changes

evidolob mentioned this pull request Aug 23, 2017

Language Server Protocol: Rename feature #1806

Closed

gazarenkov mentioned this pull request Sep 4, 2017

Support for Language Server Protocol - part 2 #2109

Closed

8 tasks

tsmaeder force-pushed the 5485_apply_workspace_edit branch from 2ddb668 to 383a769 Compare September 4, 2017 14:28

Add ApplyWorkspaceEditAction

2ddd8fa

Signed-off-by: Thomas Mäder <tmader@redhat.com>

tsmaeder force-pushed the 5485_apply_workspace_edit branch from 383a769 to 2ddd8fa Compare September 6, 2017 09:24

Fix copyright statement

7ab9023

Signed-off-by: Thomas Mäder <tmader@redhat.com>

tsmaeder force-pushed the 5485_apply_workspace_edit branch from a783052 to 7ab9023 Compare September 6, 2017 11:48

vparfonov reviewed Sep 6, 2017

View reviewed changes

vparfonov merged commit 7faecba into eclipse-che:master Sep 7, 2017

vparfonov added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 8, 2017

vparfonov added this to the 5.18.0 milestone Sep 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5485 apply workspace edit #5955

5485 apply workspace edit #5955

tsmaeder commented Aug 9, 2017 •

edited

Loading

codenvy-ci commented Aug 9, 2017

codenvy-ci commented Aug 9, 2017

benoitf commented Aug 9, 2017

codenvy-ci commented Aug 9, 2017

benoitf commented Aug 9, 2017

RomanNikitenko Aug 9, 2017

benoitf commented Aug 16, 2017

codenvy-ci commented Aug 16, 2017

vparfonov Aug 17, 2017

vparfonov Aug 17, 2017

vparfonov left a comment

vparfonov Aug 17, 2017

vparfonov Aug 17, 2017

vparfonov Aug 17, 2017

vparfonov commented Aug 22, 2017

tsmaeder commented Sep 6, 2017

benoitf commented Sep 6, 2017

vparfonov left a comment

codenvy-ci commented Sep 6, 2017

slemeur commented Sep 7, 2017 •

edited

Loading


		private File createTempIoFile(VirtualFile parent, String prefix, String suffix) throws IOException {

+                  	};
+                  }
+              }

5485 apply workspace edit #5955

5485 apply workspace edit #5955

Conversation

tsmaeder commented Aug 9, 2017 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

Docs PR

codenvy-ci commented Aug 9, 2017

codenvy-ci commented Aug 9, 2017

benoitf commented Aug 9, 2017

codenvy-ci commented Aug 9, 2017

benoitf commented Aug 9, 2017

RomanNikitenko Aug 9, 2017

Choose a reason for hiding this comment

benoitf commented Aug 16, 2017

codenvy-ci commented Aug 16, 2017

vparfonov Aug 17, 2017

Choose a reason for hiding this comment

vparfonov Aug 17, 2017

Choose a reason for hiding this comment

vparfonov left a comment

Choose a reason for hiding this comment

vparfonov Aug 17, 2017

Choose a reason for hiding this comment

vparfonov Aug 17, 2017

Choose a reason for hiding this comment

vparfonov Aug 17, 2017

Choose a reason for hiding this comment

vparfonov commented Aug 22, 2017

tsmaeder commented Sep 6, 2017

benoitf commented Sep 6, 2017

vparfonov left a comment

Choose a reason for hiding this comment

codenvy-ci commented Sep 6, 2017

slemeur commented Sep 7, 2017 • edited Loading

tsmaeder commented Aug 9, 2017 •

edited

Loading

slemeur commented Sep 7, 2017 •

edited

Loading