Update Che Dev Dockerfile #5959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashboard now builds with docker by default so `-Pnative` needs to be set. I also made this update at [https://github.com/eclipse/che/wiki/Development-Workflow](https://github.com/eclipse/che/wiki/Development-Workflow)
JamesDrummond
added
the
kind/task
|
Can one of the admins verify this patch? |
benoitf
approved these changes
Aug 9, 2017
|
@james it seems eca is invalid |
|
Can one of the admins verify this patch? |
|
@benoitf What does eca stand for? What is the current eclipse policy to merge pull requests? Is it two reviews of approval before merge? Currently it allows me to merge after one review(you) but I want to make sure I am following policy. |
|
Eca is signing pull requests: https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=598b6e9cb0674 And yes we should wait another reviewer |
riuvshin
approved these changes
Aug 9, 2017
|
@benoitf Thanks for pointing that out. I added this to the conversation. |
dmytro-ndp
pushed a commit
to dmytro-ndp/che
that referenced
this pull request
Aug 16, 2017
Dashboard now builds with docker by default so `-Pnative` needs to be set. I also made this update at [https://github.com/eclipse/che/wiki/Development-Workflow](https://github.com/eclipse/che/wiki/Development-Workflow) Signed-off-by: James Drummond james@devcomb.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard now builds with docker by default so
-Pnativeneeds to be set. I also made this update at https://github.com/eclipse/che/wiki/Development-WorkflowSigned-off-by: James Drummond james@devcomb.com