CHE-5274. Do not skip setting focus on element when window is displayed #5968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y displayed Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
added
the
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3335/ |
dkuleshov
approved these changes
Aug 11, 2017
SkorikSergey
approved these changes
Aug 15, 2017
vparfonov
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We skip some logic for Window#show(Focusable) here when window is displayed.
But we can have use cases when window is displayed but focus for the target element is lost.
One of these is described in the issue #5274:
So I think we shouldn't skip setting focus on element when window is displayed
What issues does this PR fix or reference?
#5274
Changelog
Do not skip setting focus on element when window is displayed
Signed-off-by: Roman Nikitenko rnikiten@redhat.com