Fix OpenShiftConnector.inspectImage() to resolve issue in OS 3.6+ #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenShiftConnector.inspectImage() uses pods to figure out a workspaces docker image. Previously, this was not a problem as it would match the imagestream tag we create earlier. However, in OpenShift 3.6 and higher, it seems like pods created by deployments use the sha256 of the image as an identifier, and so this fails. This means that workspaces fail to start due to imagestream not found. To resolve this issue, we instead get the image name through the deployment, which does have the correct value. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ci-build |
benoitf
approved these changes
Aug 16, 2017
ibuziuk
approved these changes
Aug 16, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3407/ |
slemeur
added
the
kind/task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
OpenShiftConnector.inspectImage() uses pods to figure out a workspaces docker image. Previously, this was not a problem as it would match the imagestream tag we create earlier. However, in OpenShift 3.6 and higher, it seems like pods created by deployments use the sha256 of the image as an identifier, and so this fails. This means that workspaces fail to start due to imagestream not found.
To resolve this issue, we instead get the image name through the deployment, which does have the correct value.
Changelog
(bugfix, update to support OpenShift 3.6+)
Release Notes
(bugfix)
Note: This is PR #6008 rebased onto master.