CHE-4509: Fix project name validator for rename action #6011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitrii Bocharov <dbocharo@redhat.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@bdshadow it seems that you've replaced space characters by "tab" characters |
Signed-off-by: Dmitrii Bocharov <dbocharo@redhat.com>
|
@benoitf forgot to change default eclipse tabs to spaces. |
vparfonov
approved these changes
Aug 17, 2017
riuvshin
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitrii Bocharov dbocharo@redhat.com
What does this PR do?
Fixes the validation of the project name during rename process
What issues does this PR fix or reference?
#4509
Changelog
ProjectNameValidatorhad incorrectisValidNameimplementation. It saidtruefor almost all values.