Workaround for ImageStreamTags issue on OpenShift 3.6 #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor adjustment to how image name is set when creating a workspace on OpenShift. On OpenShift 3.6, it seems that using an ImageStreamTag in a Deployment spec causes the deployment to have null status, which causes kubernetes-client to throw an NPE. We still need to decide if this is to be a longer term solution, and if removing ImageStreamTags completely is a good option Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
benoitf
approved these changes
Aug 17, 2017
|
Note also that this PR should resolve the scale down issue we've been facing, and that was worked around in PR #6017. |
ibuziuk
approved these changes
Aug 17, 2017
ibuziuk
added a commit
to ibuziuk/che
that referenced
this pull request
Aug 17, 2017
…penShift 3.6 Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
ibuziuk
added a commit
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
slemeur
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce a minor workaround for an ImageStreamTag issue on OpenShift 3.6+.
Currently, when Che attempts to delete a deployment, the Kubernetes client throws a NullPointerException and workspace cleanup fails. After some testing, it seems like the Deployment status is null only if the docker image specified for the deployment is an ImageStreamTag. If instead the Deployment is specified to use a docker image from e.g. the docker hub, the Deployment's status is not null and it is deleted successfully.
This change replaces the docker pull spec we use for Deployments with the underlying image they refer to.
This is not meant to be a long-term fix. We need to decide if we want to keep trying to use ImageStreams and ImageStreamTags, or if we want to find a better solution.
What issues does this PR fix or reference?
Failure to stop workspaces when running Che on OpenShift 3.6 and higher.
Changelog
(bugfix, OpenShift 3.6 support)
Release Notes
(bugfix, OpenShift 3.6 support)