#5750 fix cursor position after completion proposal inserted #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
dkuleshov
approved these changes
Aug 17, 2017
|
IMHO test would be great as I saw many times bugs around cursor position after code completion. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3415/ |
vparfonov
approved these changes
Aug 18, 2017
added 2 commits
August 19, 2017 11:11
…/che into fixCursorPosition Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com> # Conflicts: # plugins/plugin-languageserver/che-plugin-languageserver-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/editor/codeassist/CompletionItemBasedCompletionProposal.java
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3446/ |
vparfonov
approved these changes
Aug 19, 2017
slemeur
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix cursor position after completion proposal inserted
What issues does this PR fix or reference?
#5750