Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting #6019: Workaround for ImageStreamTags issue on OpenShift 3.6 #6023

Merged
merged 1 commit into from Aug 17, 2017

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Aug 17, 2017

Reverting #6019
On OSIO keep getting failure during workspace creation if there are more than one is presented:


2017-08-17 11:02:10,307[aceSharedPool-6]  [ERROR] [o.e.c.a.w.s.WorkspaceManager 780]    - Multiple ImageStreamTags found for name latest
--
  | org.eclipse.che.api.core.ServerException: Multiple ImageStreamTags found for name latest
  | at org.eclipse.che.api.environment.server.CheEnvironmentEngine.startInstance(CheEnvironmentEngine.java:1012)
  | at org.eclipse.che.api.environment.server.CheEnvironmentEngine.startEnvironmentQueue(CheEnvironmentEngine.java:813)
  | at org.eclipse.che.api.environment.server.CheEnvironmentEngine.start(CheEnvironmentEngine.java:268)
  | at org.eclipse.che.api.workspace.server.WorkspaceRuntimes.startEnvironmentAndPublishEvents(WorkspaceRuntimes.java:712)
  | at org.eclipse.che.api.workspace.server.WorkspaceRuntimes.access$100(WorkspaceRuntimes.java:106)
  | at org.eclipse.che.api.workspace.server.WorkspaceRuntimes$StartTask.call(WorkspaceRuntimes.java:977)
  | at org.eclipse.che.api.workspace.server.WorkspaceRuntimes$StartTask.call(WorkspaceRuntimes.java:941)
  | at org.eclipse.che.commons.lang.concurrent.CopyThreadLocalCallable.call(CopyThreadLocalCallable.java:30)
  | at java.util.concurrent.FutureTask.run(FutureTask.java:266)
  | at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
  | at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
  | at java.lang.Thread.run(Thread.java:748)
  | Caused by: org.eclipse.che.api.core.ServerException: Multiple ImageStreamTags found for name latest
  | at org.eclipse.che.plugin.docker.machine.MachineProviderImpl.startService(MachineProviderImpl.java:395)
  | at org.eclipse.che.api.environment.server.CheEnvironmentEngine.lambda$startEnvironmentQueue$6(CheEnvironmentEngine.java:785)
  | at org.eclipse.che.api.environment.server.CheEnvironmentEngine.startInstance(CheEnvironmentEngine.java:952)
  | ... 11 common frames omitted
  | Caused by: org.eclipse.che.plugin.openshift.client.exception.OpenShiftException: Multiple ImageStreamTags found for name latest
  | at org.eclipse.che.plugin.openshift.client.OpenShiftConnector.getImageStreamTagFromRepo(OpenShiftConnector.java:1083)
  | at org.eclipse.che.plugin.openshift.client.OpenShiftConnector.inspectContainer(OpenShiftConnector.java:593)
  | at org.eclipse.che.plugin.docker.machine.MachineProviderImpl.checkContainerIsRunning(MachineProviderImpl.java:701)
  | at org.eclipse.che.plugin.docker.machine.MachineProviderImpl.startService(MachineProviderImpl.java:350)
  | ... 13 common frames omitted


…penShift 3.6

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk requested a review from l0rd as a code owner August 17, 2017 11:22
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@codenvy-ci
Copy link

Can one of the admins verify this patch?

@riuvshin
Copy link
Contributor

ci-build

@codenvy-ci
Copy link

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very frustrating, and another argument for getting rid of ImageStreamTags entirely.

@ibuziuk ibuziuk merged commit ee09e10 into eclipse-che:master Aug 17, 2017
@slemeur slemeur added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Sep 28, 2017
@slemeur slemeur added this to the 5.17.0 milestone Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants