Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconfigured as project top level folder will marked as detected project #6184

Merged
merged 3 commits into from
Sep 11, 2017

Conversation

vparfonov
Copy link
Contributor

Signed-off-by: Vitalii Parfonov vparfonov@redhat.com

What does this PR do?

Top level folder (folders in the /projects) will marked as detected project

What issues does this PR fix or reference?

#6161

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov vparfonov added kind/bug Outline of a bug - must adhere to the bug report template. sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/ide labels Sep 7, 2017
@vparfonov vparfonov added this to the 5.18.0 milestone Sep 7, 2017
@vparfonov vparfonov self-assigned this Sep 7, 2017
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Copy link
Contributor

@gazarenkov gazarenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that just added top level folder will be marked as "problematic project" but after next IDE loading it will be automatically detected as Blank project?

@codenvy-ci
Copy link

@vparfonov
Copy link
Contributor Author

vparfonov commented Sep 8, 2017

@gazarenkov No. It still will by Blank but marked with error, missing configuration settings in workspace config.

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@codenvy-ci
Copy link

@vparfonov vparfonov merged commit 4dfeb91 into master Sep 11, 2017
@vparfonov vparfonov deleted the che#6161 branch September 11, 2017 12:15
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants