CHE-6191: FIx bug when can not open project in workspace with custom … #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
added
the
kind/bug
vparfonov
reviewed
Sep 8, 2017
| @@ -58,9 +61,11 @@ | |||
| public GitChangesDetector( | |||
| RequestTransmitter transmitter, | |||
| FileWatcherManager manager, | |||
| ProjectManager projectManager, | |||
There was a problem hiding this comment.
Use here Provider<ProjectManager>
vparfonov
reviewed
Sep 8, 2017
| @@ -55,9 +58,11 @@ | |||
| public GitIndexChangedDetector( | |||
| RequestTransmitter transmitter, | |||
| FileWatcherManager manager, | |||
| ProjectManager projectManager, | |||
There was a problem hiding this comment.
Use here Provider<ProjectManager>
vparfonov
reviewed
Sep 8, 2017
|
|
||
| @Inject | ||
| public GitStatusProvider(GitConnectionFactory gitConnectionFactory) { | ||
| public GitStatusProvider( | ||
| GitConnectionFactory gitConnectionFactory, ProjectManager projectManager) { |
There was a problem hiding this comment.
Use here Provider<ProjectManager>
…custom WORKDIR property
vparfonov
approved these changes
Sep 8, 2017
|
Build # 3609 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3609/ to view the results. |
|
QA in progress |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3649/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…WORKDIR property
What does this PR do?
FIx bug when can not open project in workspace with custom WORKDIR property
What issues does this PR fix or reference?
fixes #6191
Changelog
FIx bug when can not open project in workspace with custom WORKDIR property
Release Notes
N/A
Docs PR
N/A