Implemented top method in OpenShiftConnector #6221
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Signed-off-by: jpinkney <josh.pinkney@mail.utoronto.ca>
|
ci-build |
benoitf
added
kind/task
|
Build # 3665 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3665/ to view the results. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3713/ |
| .redirectingOutput() | ||
| .redirectingError() | ||
| .exec(command)) { | ||
| Thread.sleep(2500); |
There was a problem hiding this comment.
is it mandatory this wait ?
There was a problem hiding this comment.
I asked @snjeza and was told that it was copied from the exec method. I believe it was copied from this https://github.com/JPinkney/che/blob/0c86b9b4c25e045e657a1dbca850fdb1c3c78e5d/plugins/plugin-docker/che-plugin-openshift-client/src/main/java/org/eclipse/che/plugin/openshift/client/OpenShiftConnector.java#L1136-L1155 as far as I can see the ExecutorService declared isn't even used except for shutting down in the finally block so this line wouldn't be needed.
|
ci-build |
|
Build # 3762 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3762/ to view the results. |
benoitf
removed
the
status/code-review
Signed-off-by: jpinkney josh.pinkney@mail.utoronto.ca
What does this PR do?
Rebases #4466 onto master branch.
What issues does this PR fix or reference?
Rebases #4466
Part of: redhat-developer/rh-che#322
Changelog
Implemented top method in OpenShiftConnector
Release Notes
Top method implemented in OpenShiftConnector
Docs PR