Implemented getVersion in OpenShiftConnector #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPinkney
force-pushed
the
getVersionOSC
branch
from
729d6e8
to
9dfa7b1
Compare
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
l0rd
reviewed
Sep 13, 2017
| openShiftClient.adapt(OkHttpClient.class), | ||
| OpenShiftConfig.wrap(openShiftClient.getConfiguration())); | ||
| String versionString = client.getVersion(); | ||
| if (versionString == null || versionString.isEmpty()) { |
There was a problem hiding this comment.
You should use method isNullOrEmpty
There was a problem hiding this comment.
Fixed and updated.
| @@ -266,6 +271,25 @@ public void onEvent(ServerIdleEvent event) { | |||
| }); | |||
| } | |||
|
|
|||
| @Override | |||
| public Version getVersion() throws IOException { | |||
| @SuppressWarnings("resource") | |||
There was a problem hiding this comment.
Why do we need SuppressWarnings? Can't we avoid it?
There was a problem hiding this comment.
It seems like it wasn't needed. I've removed it and updated the code.
benoitf
reviewed
Sep 13, 2017
| @@ -0,0 +1,44 @@ | |||
| /** | |||
| * ***************************************************************************** Copyright (c) | |||
There was a problem hiding this comment.
Fixed header's in OpenShiftClientExtension and OpenShiftVersion.
|
ci-build |
benoitf
added
kind/task
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3664/ |
l0rd
approved these changes
Sep 18, 2017
l0rd
approved these changes
Sep 29, 2017
|
@JPinkney sorry you need to rebase this PR 😞 |
Signed-off-by: jpinkney <josh.pinkney@mail.utoronto.ca>
JPinkney
force-pushed
the
getVersionOSC
branch
from
497c09e
to
d34cf8f
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3902/ |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jpinkney josh.pinkney@mail.utoronto.ca
What does this PR do?
Rebases #4363 onto master branch.
What issues does this PR fix or reference?
Rebase of: #4363
Part of: redhat-developer/rh-che#322
Changelog
Implemented getVersion in OpenShiftConnector
Release Notes
N/A
Docs PR