-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented getVersion in OpenShiftConnector #6222
Conversation
729d6e8
to
9dfa7b1
Compare
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openShiftClient.adapt(OkHttpClient.class), | ||
OpenShiftConfig.wrap(openShiftClient.getConfiguration())); | ||
String versionString = client.getVersion(); | ||
if (versionString == null || versionString.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use method isNullOrEmpty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and updated.
@@ -266,6 +271,25 @@ public void onEvent(ServerIdleEvent event) { | |||
}); | |||
} | |||
|
|||
@Override | |||
public Version getVersion() throws IOException { | |||
@SuppressWarnings("resource") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need SuppressWarnings
? Can't we avoid it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it wasn't needed. I've removed it and updated the code.
@@ -0,0 +1,44 @@ | |||
/** | |||
* ***************************************************************************** Copyright (c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headers seem broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed header's in OpenShiftClientExtension and OpenShiftVersion.
ci-build |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3664/ |
@JPinkney sorry you need to rebase this PR 😞 |
Signed-off-by: jpinkney <josh.pinkney@mail.utoronto.ca>
497c09e
to
d34cf8f
Compare
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3902/ |
Signed-off-by: jpinkney josh.pinkney@mail.utoronto.ca
What does this PR do?
Rebases #4363 onto master branch.
What issues does this PR fix or reference?
Rebase of: #4363
Part of: redhat-developer/rh-che#322
Changelog
Implemented getVersion in OpenShiftConnector
Release Notes
N/A
Docs PR