Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common fixes for master #6270

Merged
merged 3 commits into from
Sep 14, 2017
Merged

Common fixes for master #6270

merged 3 commits into from
Sep 14, 2017

Conversation

musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Sep 14, 2017 •
edited
Loading

What does this PR do?

  • Apply using of actual workspace configuration for checking LSP for C# language
  • Change steps in the test (CheckMainFeatureForCharpLanguageTest) according to new asp-sample
  • Change keybindings list according to latest changes in the widget
    @tolusha @vparfonov @Ohrimenko1988

What issues does this PR fix or reference?

#6269

@musienko-maxim musienko-maxim force-pushed the common_fixes_for_master branch 5 times, most recently from ef0a561 to ee3a965 Compare September 14, 2017 10:29
@tolusha
Copy link
Contributor

tolusha commented Sep 14, 2017

Don't forget to update codenvy and saas projects too.

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3683/

@musienko-maxim musienko-maxim merged commit d39f28f into master Sep 14, 2017
@musienko-maxim musienko-maxim deleted the common_fixes_for_master branch September 14, 2017 16:30
@slemeur slemeur added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Sep 28, 2017
@slemeur slemeur added this to the 5.18.0 milestone Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov approved these changes

@tolusha tolusha tolusha approved these changes

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
5.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@musienko-maxim @tolusha @codenvy-ci @vparfonov @Ohrimenko1988 @slemeur