Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker images build #6372

Merged
merged 11 commits into from
Sep 21, 2017
Merged

fix docker images build #6372

merged 11 commits into from
Sep 21, 2017

Conversation

riuvshin
Copy link
Contributor

@riuvshin riuvshin commented Sep 20, 2017 •
edited
Loading

What does this PR do?

fix build of docker images

after adding set -u docker images build was failed:

../build.include: line 83: IMAGE_ALIASES: unbound variable

@riuvshin riuvshin added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 20, 2017
@riuvshin riuvshin self-assigned this Sep 20, 2017
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@riuvshin riuvshin changed the title remove set -u from build.include script fix dockerimages build Sep 20, 2017
@riuvshin riuvshin changed the title fix dockerimages build fix docker images build Sep 20, 2017
@riuvshin riuvshin added this to the 5.19.0 milestone Sep 20, 2017
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3745/

@benoitf
Copy link
Contributor

benoitf commented Sep 21, 2017

I would prefer to fix the build.include instead of removing the set -u flag

initializing values in build.include with the pattern
`FOO=${FOO:-default}``
should solve the issue of IMAGE_ALIASES (without having to add empty value in all the .sh scripts)

Roman Iuvshyn added 2 commits September 21, 2017 10:59
@riuvshin
Copy link
Contributor Author

@benoitf updated :)

@riuvshin riuvshin merged commit 66d6f94 into master Sep 21, 2017
@riuvshin riuvshin deleted the riuvshin-patch-1 branch September 21, 2017 08:13
riuvshin pushed a commit that referenced this pull request Sep 21, 2017
fix docker images build (#6372)
a092d97 
* fix docker images build
@codenvy-ci
Copy link

Build # 3752 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3752/ to view the results.

musienko-maxim pushed a commit that referenced this pull request Sep 22, 2017
fix docker images build (#6372)
e44cb04 
* fix docker images build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@riuvshin riuvshin

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
5.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@riuvshin @codenvy-ci @benoitf