Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EclipseLink to v2.7.0 #6377

Merged
merged 1 commit into from Sep 27, 2017
Merged

Update EclipseLink to v2.7.0 #6377

merged 1 commit into from Sep 27, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Sep 21, 2017

What does this PR do?

Update to the newer EclipseLink version
Packages have been refactored since previous version, adapting the classes.

note: some dependencies have been updated (avoid eclipselink dependencies as it contains some API of javax.persistence package)
then, when tests are running, Java runtime complains about siganture mismatch between eclipse-link jar and javax-persistence.jar (same package but with two origins)

By using org.eclipse.persistence.core and org.eclipse.persistence.jpa artifacts, the dependencies are more explicit and we select only required dependencies.

What issues does this PR fix or reference?

#5326

Release Notes

N/A

Docs PR

N/A

Change-Id: I4752a79e1badb2bf36594a3f7c1928569200d2a5
Signed-off-by: Florent BENOIT fbenoit@redhat.com

@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/osio labels Sep 21, 2017
@benoitf benoitf self-assigned this Sep 21, 2017
@codenvy-ci
Copy link

Build # 3754 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3754/ to view the results.

@benoitf benoitf force-pushed the update-eclipse-link branch 2 times, most recently from b2bd731 to 374fd6f Compare September 21, 2017 12:28
@codenvy-ci
Copy link

@benoitf benoitf changed the title wip - do not merge : Update EclipseLink to v2.7.0 Update EclipseLink to v2.7.0 Sep 22, 2017
@benoitf
Copy link
Contributor Author

benoitf commented Sep 22, 2017

this PR will now fail as it requires che-dependencies eclipse-che/che-dependencies#58

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Sep 22, 2017
@codenvy-ci
Copy link

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

ci-test

@codenvy-ci
Copy link

Build # 3815 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3815/ to view the results.

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@codenvy-ci
Copy link

note: some dependencies have been updated (avoid eclipselink dependencies as it contains some API of javax.persistence package)
then, when tests are running, Java runtime complains about siganture mismatch between eclipse-link jar and javax-persistence.jar (same package but with two origins)

By using org.eclipse.persistence.core and org.eclipse.persistence.jpa the dependencies are more explicit and we select only required dependencies.

Change-Id: I4752a79e1badb2bf36594a3f7c1928569200d2a5
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
@benoitf
Copy link
Contributor Author

benoitf commented Sep 27, 2017

oops no-one has approved this one

@benoitf benoitf merged commit e527363 into master Sep 27, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 27, 2017
@benoitf benoitf added this to the 5.19.0 milestone Sep 27, 2017
@codenvy-ci
Copy link

@benoitf benoitf deleted the update-eclipse-link branch December 5, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants