-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
as we're at the beginning of sprint, it's a good time ;-) |
fba5f75
to
5557f8e
Compare
hello, any news why it's blocked ? All PRs are building successfully |
As for me, I would say if there is no strong need - postpone this task to Che6. Too scary to merge. |
I would say the sooner is the better as we have 3 weeks of testing it (as release is happening in the end of the sprint). Also it's easy to revert this kind of update |
note that EclipseLink 2.6.2 Release has been released on |
@benoitf Did you run integration test for this changes? |
@vparfonov you mean the profile |
I mean our daily selenium tests |
if it's about the profile it has been checked there
|
@vparfonov we can run daily selenium tests on top of a PR by jenkins ? |
yes add comment |
but i think you can't do it with your changes in case you Che should depend on not merged changes in che-dependencies, maybe will be better start it on some acceptance server |
@vparfonov I added on top of the PR a "commit to be removed" to not require external dependencies (this commit contains the versions added in this PR) |
@vparfonov here is the result: https://ci.codenvycorp.com/job/che-pullrequests-test/29//Selenium_tests_report |
@musienko-maxim can you check report |
The stable part of tests is not broken |
so is it ok to merge that PR ? |
In general, I'm +1. But if it has any, event theoretical, chances to delay eclipse-che/che#5362 I would say we should merge it after 5632 |
AFAIK this PR is ready to merge while other is still a work in progress. |
This pr is delayed in an artifical manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up2you
ok, I will check multi user branch after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to you, if this does not break something Im OK with this
What does this PR do?
Update to EclipseLink 2.7.0
dependencies used are
CQ for org.glassfish:javax.json:jar:1.0.4:test is https://dev.eclipse.org/ipzilla/show_bug.cgi?id=14311
the other are eclipse dependencies.
What issues does this PR fix or reference?
eclipse-che/che#5326
Require also
and