Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Update to EclipseLink 2.7.0 #58

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Update to EclipseLink 2.7.0 #58

merged 1 commit into from
Sep 27, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Sep 22, 2017

What does this PR do?

Update to EclipseLink 2.7.0

dependencies used are

[INFO] +- org.eclipse.persistence:javax.persistence:jar:2.2.0:test
[INFO] +- org.eclipse.persistence:org.eclipse.persistence.core:jar:2.7.0:test
[INFO] |  +- org.eclipse.persistence:org.eclipse.persistence.asm:jar:2.7.0:test
[INFO] |  \- org.glassfish:javax.json:jar:1.0.4:test
[INFO] +- org.eclipse.persistence:org.eclipse.persistence.jpa:jar:2.7.0:test
[INFO] |  +- org.eclipse.persistence:org.eclipse.persistence.antlr:jar:2.7.0:test
[INFO] |  \- org.eclipse.persistence:org.eclipse.persistence.jpa.jpql:jar:2.7.0:test

CQ for org.glassfish:javax.json:jar:1.0.4:test is https://dev.eclipse.org/ipzilla/show_bug.cgi?id=14311
the other are eclipse dependencies.

What issues does this PR fix or reference?

eclipse-che/che#5326

Require also

@benoitf
Copy link
Contributor Author

benoitf commented Sep 22, 2017

as we're at the beginning of sprint, it's a good time ;-)

@benoitf
Copy link
Contributor Author

benoitf commented Sep 25, 2017

hello, any news why it's blocked ? All PRs are building successfully

@skabashnyuk
Copy link
Contributor

As for me, I would say if there is no strong need - postpone this task to Che6. Too scary to merge.
@riuvshin wdyt?

@benoitf
Copy link
Contributor Author

benoitf commented Sep 25, 2017

I would say the sooner is the better as we have 3 weeks of testing it (as release is happening in the end of the sprint). Also it's easy to revert this kind of update

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

note that EclipseLink 2.6.2 Release has been released on December 22, 2015

@vparfonov
Copy link
Contributor

@benoitf Did you run integration test for this changes?

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

@vparfonov you mean the profile -Pintegration ?

@vparfonov
Copy link
Contributor

I mean our daily selenium tests

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

if it's about the profile it has been checked there
https://ci.codenvycorp.com/job/che-pullrequests-build/3782/

19:04:43 Executing Maven:  -B -f /home/codenvy/workspace/che-pullrequests-build/pom.xml -Dmaven.repo.local=/home/codenvy/workspace/che-pullrequests-build/.repository clean install -U -Pintegration

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

@vparfonov we can run daily selenium tests on top of a PR by jenkins ?

@vparfonov
Copy link
Contributor

vparfonov commented Sep 26, 2017

yes add comment ci-test

@vparfonov
Copy link
Contributor

vparfonov commented Sep 26, 2017

but i think you can't do it with your changes in case you Che should depend on not merged changes in che-dependencies, maybe will be better start it on some acceptance server

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

@vparfonov I added on top of the PR a "commit to be removed" to not require external dependencies (this commit contains the versions added in this PR)

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

@vparfonov
Copy link
Contributor

vparfonov commented Sep 26, 2017

@musienko-maxim can you check report

@musienko-maxim
Copy link

The stable part of tests is not broken

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

so is it ok to merge that PR ?

@skabashnyuk
Copy link
Contributor

In general, I'm +1. But if it has any, event theoretical, chances to delay eclipse-che/che#5362 I would say we should merge it after 5632

@benoitf
Copy link
Contributor Author

benoitf commented Sep 26, 2017

AFAIK this PR is ready to merge while other is still a work in progress.

@benoitf
Copy link
Contributor Author

benoitf commented Sep 27, 2017

This pr is delayed in an artifical manner.
The PR that you reference was not yet submitted the time this PR has been submitted. Also this other CQ has cqs not approved yet
About trying to make some PR more important than others, I don't see the rule on https://www.eclipse.org/projects/dev_process/development_process.php#2_1_Open_Source_Rules_of_Engagement
If some people are not working with short-live branch process, there is also no reason to block the work from other people.

Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up2you

@benoitf
Copy link
Contributor Author

benoitf commented Sep 27, 2017

ok, I will check multi user branch after

Copy link

@riuvshin riuvshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you, if this does not break something Im OK with this

@benoitf benoitf merged commit a3a8886 into master Sep 27, 2017
@benoitf benoitf deleted the update-eclipselink branch September 27, 2017 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants