Add possibility to disable DockerInstanceStopDetector #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is needed for OpenShift infra where getting events is not supported due to security limits. To disable containers stop detector variable CHE_DOCKER_ENABLE__CONTAINER__STOP__DETECTOR=false should be defined. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
skabashnyuk
approved these changes
Sep 25, 2017
sleshchenko
approved these changes
Sep 25, 2017
| @@ -89,7 +97,9 @@ public DockerInstanceStopDetector( | |||
| * @param workspaceId id of a workspace that owns machine | |||
| */ | |||
| public void startDetection(String containerId, String machineId, String workspaceId) { | |||
| instances.put(containerId, Pair.of(machineId, workspaceId)); | |||
| if (enableDetector) { | |||
There was a problem hiding this comment.
I'd name this variable as isEnabled
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3789/ |
|
there is a missing test |
|
yes |
riuvshin
approved these changes
Sep 25, 2017
|
@garagatyi I don't see the unit test ? |
|
also I don't see any labels set and milestone |
garagatyi
added
the
kind/task
|
I didn't add tests. |
|
labels and milestone must be defined when merging a PR |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3801/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is needed for OpenShift infra where getting events
is not supported due to security limits.
To disable containers stop detector variable
CHE_DOCKER_ENABLE__CONTAINER__STOP__DETECTOR=false should be
defined.
What issues does this PR fix or reference?
Changelog
Add possibility to disable DockerInstanceStopDetector
Release Notes
Docs PR