Do not store preferences when workspace has already stopped #6464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
added
kind/bug
vparfonov
reviewed
Sep 27, 2017
| @@ -481,7 +490,10 @@ public ActiveRuntime getActiveRuntime() { | |||
|
|
|||
| @Override | |||
| public void onWindowClosing(WindowActionEvent event) { | |||
| appStateManager.get().persistWorkspaceState(getWorkspaceId()); | |||
| Workspace workspace = getWorkspace(); | |||
There was a problem hiding this comment.
What reason call getWorkspace() here?
There was a problem hiding this comment.
Because, onWindowClosing may be called when workspace has stopped. And calling getWorkspaceId will throw an exception, because current workspace if not provided. So we'll be on the safe side, we'll check if we have a workspace as initialized object.
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3848/ |
vparfonov
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal fix the problem when IDE could rewrite IDE state when workspace has already stopped. It means that when workspace stops, IDE stores opened files to the preferences and when it looses the focus - state could be rewritten with empty values.
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
#6461
Changelog
Do not store preferences when workspace has already stopped
Release Notes
N/A
Docs PR
N/A