Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to the full text search results #6522

Merged
merged 5 commits into from
Oct 4, 2017
Merged

Add pagination to the full text search results #6522

merged 5 commits into from
Oct 4, 2017

Conversation

svor
Copy link
Contributor

@svor svor commented Oct 2, 2017

What does this PR do?

Provides an ability to help paginate results of full text search operation. The default number of files returned for each page is 30, each file can contain many occurrences.
pag

What issues does this PR fix or reference?

#6143

Release Notes

Add pagination to showing the result of full text search operation

Docs PR

@svor svor added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 2, 2017
@svor svor added this to the 5.19.0 milestone Oct 2, 2017
@svor svor self-assigned this Oct 2, 2017
@svor svor requested a review from vparfonov October 2, 2017 12:24
@codenvy-ci
Copy link

@svor svor requested a review from tolusha as a code owner October 2, 2017 15:50
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 2, 2017
@codenvy-ci
Copy link

@svor
Copy link
Contributor Author

svor commented Oct 3, 2017

ci-test

@slemeur
Copy link
Contributor

slemeur commented Oct 3, 2017

Can we use the fontawesome icons in the buttons, instead of < and > ?

@svor
Copy link
Contributor Author

svor commented Oct 3, 2017

@slemeur We can
These are Font Awesome icons:
selection_013
I'll commit changes.

@codenvy-ci
Copy link

@svor svor changed the title CHE-5729: add pagination to the full text search results Add pagination to the full text search results Oct 3, 2017
@svor
Copy link
Contributor Author

svor commented Oct 3, 2017

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@svor svor merged commit 25c16a6 into master Oct 4, 2017
@svor svor deleted the CHE-6143 branch October 4, 2017 15:08
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 4, 2017
@codenvy-ci
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants