Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to check swagger with several workspaces in an account #6548

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Oct 3, 2017

What does this PR do?

Check that a current workspace present in the 'workspaces' part of the Swagger page, if the workspaces can be more than 1.

What issues does this PR fix or reference?

#6532

@vparfonov, @tolusha

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Oct 3, 2017
String wsNameFromSwaggerPage = swagger.getWsNameFromWorkspacePage();
Assert.assertEquals(wsNameFromSwaggerPage, workspace.getName());
driver.navigate().to(swaggerUrl);
Assert.assertTrue(swagger.getWsNamesFromWorkspacePage().contains(workspace.getName()));
Copy link
Contributor

@dmytro-ndp dmytro-ndp Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code will be clear if we use static import of Asser.assertTrue here.

@musienko-maxim musienko-maxim changed the title add ability check swagger with seweral workspaces in an account Add ability check swagger with seweral workspaces in an account Oct 3, 2017
@dmytro-ndp dmytro-ndp changed the title Add ability check swagger with seweral workspaces in an account Add ability to check swagger with several workspaces in an account Oct 3, 2017
@musienko-maxim musienko-maxim merged commit 4b6f984 into master Oct 3, 2017
@musienko-maxim musienko-maxim deleted the rework_swagger_test branch October 3, 2017 14:41
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 3, 2017
@benoitf benoitf added this to the 5.19.0 milestone Oct 3, 2017
@codenvy-ci
Copy link

Build # 3963 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3963/ to view the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants