-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to check swagger with several workspaces in an account #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t current ws. exists in the list
vparfonov
approved these changes
Oct 3, 2017
benoitf
added
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
kind/task
Internal things, technical debt, and to-do tasks to be performed.
labels
Oct 3, 2017
dmytro-ndp
reviewed
Oct 3, 2017
String wsNameFromSwaggerPage = swagger.getWsNameFromWorkspacePage(); | ||
Assert.assertEquals(wsNameFromSwaggerPage, workspace.getName()); | ||
driver.navigate().to(swaggerUrl); | ||
Assert.assertTrue(swagger.getWsNamesFromWorkspacePage().contains(workspace.getName())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code will be clear if we use static import of Asser.assertTrue here.
musienko-maxim
changed the title
add ability check swagger with seweral workspaces in an account
Add ability check swagger with seweral workspaces in an account
Oct 3, 2017
dmytro-ndp
changed the title
Add ability check swagger with seweral workspaces in an account
Add ability to check swagger with several workspaces in an account
Oct 3, 2017
dmytro-ndp
approved these changes
Oct 3, 2017
tolusha
approved these changes
Oct 3, 2017
benoitf
removed
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
Oct 3, 2017
Build # 3963 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3963/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check that a current workspace present in the 'workspaces' part of the Swagger page, if the workspaces can be more than 1.
What issues does this PR fix or reference?
#6532
@vparfonov, @tolusha