CHE-6024: Add selenium test for git revert action #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
status/code-review
vparfonov
approved these changes
Oct 3, 2017
vinokurig
approved these changes
Oct 3, 2017
dmytro-ndp
reviewed
Oct 3, 2017
| new WebDriverWait(seleniumWebDriver, REDRAW_UI_ELEMENTS_TIMEOUT_SEC) | ||
| .until( | ||
| ExpectedConditions.visibilityOfElementLocated( | ||
| By.xpath("//*[contains(text(),'" + revision + "')]"))) |
There was a problem hiding this comment.
It looks strange to search on revision number in the whole page. We can potentially find the revision number in the wrong place. IMHO, it's better to restrict search by Git revert commit panel.
dmytro-ndp
reviewed
Oct 3, 2017
| @@ -98,16 +97,10 @@ public void clickOnGitStatusBarTab() { | |||
| } | |||
|
|
|||
| /** wait expected message into the IDE git status bar */ | |||
There was a problem hiding this comment.
Let's update method docs as well.
dmytro-ndp
reviewed
Oct 3, 2017
| @@ -287,6 +287,7 @@ | |||
| <exclude name="pullConflictsTest"/> | |||
| </methods> | |||
| </class> | |||
| <class name="org.eclipse.che.selenium.git.RevertCommitTest"/> | |||
There was a problem hiding this comment.
Please, don't forget to add test to the CodenvyOnpremSuite.xml and CodenvySaasSuite.xml as well.
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3959/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds selenium test for git revert action
What issues does this PR fix or reference?
#6024
not required
Release Notes
not required
Docs PR
not required