Rework tests for checking TestRunner plugin #6559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 1, 2017 14:38
… in the Page Object
…ed ids for node items
musienko-maxim
requested review from
tolusha and
svor
and removed request for
evidolob
musienko-maxim
force-pushed
the
CHE#6497
branch
from
450fa5b
to
7c8bbbb
Compare
svor
approved these changes
Oct 3, 2017
benoitf
added
status/code-review
|
Build # 3967 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3967/ to view the results. |
|
Please squash this PR before merge |
|
@garagatyi: we can use "Squash and merge" button instead, can't we? |
tolusha
reviewed
Oct 4, 2017
| private static final String METHODS_MARKED_AS_IGNORED = | ||
| "//div[contains(@id,'gwt-uid')]//div[@style='text-decoration: line-through; color: yellow;']"; | ||
|
|
||
| private static final String METHODS_MARKED_AS_PASSED = "gwt-debug-test_state_passed"; |
|
ci-build |
yes |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3978/ |
vparfonov
approved these changes
Oct 5, 2017
tolusha
approved these changes
Oct 5, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We've have unexpected unstable behavior tests related on TestRunner plugin. This PR add special ids for more clear using of web elements for result nodes and avoiding unstable steps in the selenium tests. Also it will allow more clarify to understand of potential problems during interaction of the tests and IDE.
What issues does this PR fix or reference?
#6497
@svor, @vparfonov, @tolusha