Add capturing of a html dump after failing a test #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
the
status/code-review
tolusha
reviewed
Oct 5, 2017
| @@ -306,9 +307,13 @@ private void captureScreenshot(ITestResult result, SeleniumWebDriver webDriver) | |||
| String filename = NameGenerator.generate(testName + "_", 8) + ".png"; | |||
|
|
|||
| try { | |||
| String pageSource = webDriver.getPageSource(); | |||
There was a problem hiding this comment.
Add a new method to dump page.
benoitf
added
the
kind/task
tolusha
reviewed
Oct 5, 2017
| Files.createDirectories(dmpDirectory.getParent()); | ||
| Files.write(dmpDirectory, pageSource.getBytes(), StandardOpenOption.CREATE); | ||
| } catch (WebDriverException | IOException e) { | ||
| LOG.error(format("Can't capture screenshot for test %s", testName), e); |
tolusha
reviewed
Oct 5, 2017
| @@ -321,6 +322,19 @@ private void captureScreenshot(ITestResult result, SeleniumWebDriver webDriver) | |||
| } | |||
| } | |||
|
|
|||
| private void dumpHtmlCodeFromTheCurrentPage(ITestResult result, SeleniumWebDriver webDriver) { | |||
| String testName = result.getTestClass().getName() + "." + result.getMethod().getMethodName(); | |||
| String filename = NameGenerator.generate(testName + "_", 8) + ".png"; | |||
musienko-maxim
force-pushed
the
add_html_dump_after_failing_test
branch
from
3663cb3
to
83e7037
Compare
musienko-maxim
force-pushed
the
add_html_dump_after_failing_test
branch
from
83e7037
to
6f0191a
Compare
tolusha
approved these changes
Oct 5, 2017
vparfonov
reviewed
Oct 5, 2017
| @@ -257,6 +258,7 @@ private void captureScreenshot(ITestResult result) { | |||
|
|
|||
| collectInjectedWebDrivers(testInstance, webDrivers); | |||
| webDrivers.forEach(webDriver -> captureScreenshot(result, webDriver)); | |||
| webDrivers.forEach(webDriver -> dumpHtmlCodeFromTheCurrentPage(result, webDriver)); | |||
There was a problem hiding this comment.
Not good name for method for because you not just capture screenshot but basically ok for me
vparfonov
approved these changes
Oct 5, 2017
|
ci-build |
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4023/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes for investigating problems with failed tests the screenshots and exceptions may be not enough. This PR provides ability to capture html code from the current page for clarify of reasons of failing some specific usecases.