-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server Protocol Rename implementation #6615
Conversation
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4035/ |
if (!isStartWithProject(filePath)) { | ||
filePath = prefixProject(filePath); | ||
} | ||
String fileContent = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to chime in late, but since we'll face a similar problem with the "references" for the jdt.ls, etc. I think this approach will not scale for large sets of changes. We should be thinking towards a UI where we fetch the concrete line changes ("snippets") when we need them.
String matchedLine = change.getTextEdit().getLineText(); | ||
int startOffset = change.getTextEdit().getInLineStart(); | ||
int endOffset = change.getTextEdit().getInLineEnd(); | ||
if (matchedLine != null /*&& matchInLine != null*/) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment code
} | ||
spanElement.appendChild(textElement); | ||
|
||
// presentation.setPresentableIcon(resources.searchMatch()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment code
@@ -134,12 +150,15 @@ public void onFileOperation(final FileEvent event) { | |||
break; | |||
} | |||
} | |||
// onOpen(event.getEditor(), event.getFile(), dtoFactory, serviceClient, fileTypeRegister); | |||
// onOpen(event.getEditor(), event.getFile(), dtoFactory, serviceClient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment code
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
What does this PR do?
Add implementation of LSP Rename
What issues does this PR fix or reference?
#1806
Release Notes
Language Server Protocol Rename implementation