-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved displaying of long workspace names #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
single line on wide screen, two lines on small screen Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
added
kind/bug
Outline of a bug - must adhere to the bug report template.
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
labels
Oct 11, 2017
benoitf
approved these changes
Oct 11, 2017
@@ -1,6 +1,8 @@ | |||
navbar-dropdown-menu | |||
height inherit | |||
min-height inherit | |||
with 100% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing d ? width ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks,
fixed
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4088/ |
ashumilova
approved these changes
Oct 12, 2017
olexii4
approved these changes
Oct 12, 2017
benoitf
removed
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
Oct 12, 2017
benoitf
pushed a commit
that referenced
this pull request
Oct 14, 2017
* add che-clip-the-middle directive Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fix list of recent workspaces to display correctly long workspace names Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fix WS item to display correctly long workspace names on Workspaces page Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * update footer single line on wide screen, two lines on small screen Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * code clean-up Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fix list of recent workspaces to display correctly long workspace names
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* add che-clip-the-middle directive Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fix list of recent workspaces to display correctly long workspace names Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fix WS item to display correctly long workspace names on Workspaces page Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * update footer single line on wide screen, two lines on small screen Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * code clean-up Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fix list of recent workspaces to display correctly long workspace names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It improves displaying of long workspace names in the list of Recent workspaces in the left sidebar and in the list on Workspaces page.
Large screen
Small screen
What issues does this PR fix or reference?
fixes #6621
Release Notes
N/A - bugfix
Docs PR
N/A - bugfix