Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved displaying of long workspace names #6668

Merged
merged 6 commits into from
Oct 12, 2017
Merged

Improved displaying of long workspace names #6668

merged 6 commits into from
Oct 12, 2017

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

It improves displaying of long workspace names in the list of Recent workspaces in the left sidebar and in the list on Workspaces page.

Large screen
large

Small screen
small

What issues does this PR fix or reference?

fixes #6621

Release Notes

N/A - bugfix

Docs PR

N/A - bugfix

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
single line on wide screen, two lines on small screen

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 11, 2017
@akurinnoy akurinnoy self-assigned this Oct 11, 2017
@@ -1,6 +1,8 @@
navbar-dropdown-menu
height inherit
min-height inherit
with 100%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing d ? width ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,
fixed

@codenvy-ci
Copy link

@ashumilova ashumilova added this to the 5.19.0 milestone Oct 12, 2017
@akurinnoy akurinnoy merged commit 0953fb5 into master Oct 12, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 12, 2017
benoitf pushed a commit that referenced this pull request Oct 14, 2017
* add che-clip-the-middle directive

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix list of recent workspaces to display correctly long workspace names

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix WS item to display correctly long workspace names on Workspaces page

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* update footer

single line on wide screen, two lines on small screen

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* code clean-up

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! fix list of recent workspaces to display correctly long workspace names
@akurinnoy akurinnoy deleted the CHE-6621 branch October 24, 2017 08:36
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
* add che-clip-the-middle directive

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix list of recent workspaces to display correctly long workspace names

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix WS item to display correctly long workspace names on Workspaces page

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* update footer

single line on wide screen, two lines on small screen

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* code clean-up

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! fix list of recent workspaces to display correctly long workspace names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve display the long workspace names
5 participants