Fix initialization change markers render #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
added
kind/bug
|
ci-test |
vinokurig
approved these changes
Oct 12, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4109/ |
|
ci-test build report: |
vparfonov
approved these changes
Oct 13, 2017
musienko-maxim
approved these changes
Oct 13, 2017
RomanNikitenko
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initialization of 'Change markers render' gets project info from app context at the moment.
It works perfect when we have selection in project tree or some opened editor.
But it doesn't work for use case when we open first Editor from the Find panel - at this moment
selection in the Find panel and we haven't active editor to provide current project.
So I suggest to get project info from resource which we open for initialization this render.
What issues does this PR fix or reference?
#6687
Signed-off-by: Roman Nikitenko rnikiten@redhat.com