rework selenium tests in organization package #6717
Conversation
Ohrimenko1988
added
kind/task
| @@ -45,4 +49,12 @@ public Entrance getEntrance( | |||
| return new CookieEntrance(seleniumWebDriver); | |||
| } | |||
| } | |||
|
|
|||
| @Provides | |||
There was a problem hiding this comment.
Could you, please, explain, why did you place this provider here?
This module is dedicated for classes which are injecting SeleniumWebDriver, but I don't see such field in the TestOrganizationServiceClient, and it shouldn't be there according to the propose of that client.
There was a problem hiding this comment.
Because in che we return CheTestTestOrganizationServiceClientImpl and in the codenvy we return other implementation of TestOrganizationServiceClient interface
There was a problem hiding this comment.
I see. But the propose of CheSeleniumWebDriverRelatedModule is the classes which are injecting webdriver itself.
|
@Ohrimenko1988: there are new tests in PR like UserOrganizationTest, but I don't see any changes in tests suites. How are the new tests going to be started? |
There was a problem hiding this comment.
@dmytro-ndp tests can be started by using package running ( --test=organization.* )
| @@ -45,4 +49,12 @@ public Entrance getEntrance( | |||
| return new CookieEntrance(seleniumWebDriver); | |||
| } | |||
| } | |||
|
|
|||
| @Provides | |||
There was a problem hiding this comment.
Because in che we return CheTestTestOrganizationServiceClientImpl and in the codenvy we return other implementation of TestOrganizationServiceClient interface
|
Do you have corresponding changes in the Codenvy repo as well? |
|
@dmytro-ndp yes I have prepared changes in the codenvy/codenvy according to changes in this PR |
|
Which branch in Codenvy repo contains the changes? |
|
Thank you, @Ohrimenko1988. |
|
@dmytro-ndp yes, you are absolutely right, thx |
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4135/ |
What does this PR do?
Fix problem with duplicated organization tests in codenvy/codenvy , and add ability to run organization tests on the codenvy/codenvy
What issues does this PR fix or reference?
codenvy/codenvy#2483
Release Notes
Docs PR