Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VMware Fusion support #702

Merged
merged 2 commits into from
Mar 15, 2016
Merged

add VMware Fusion support #702

merged 2 commits into from
Mar 15, 2016

Conversation

zaps
Copy link

@zaps zaps commented Mar 14, 2016

This is a small modification to the che.sh startup script that adds an optional --vmware flag to have docker-machine use the vmwarefusion driver instead of the virtualbox driver, for those users that don't have or want to install VirtualBox.

Signed-off-by: Michael Masi <michael@eclipse.masi.cc>
@TylerJewell
Copy link

@zaps CLA looks good.
Let's go ahead and change this to --machine:fusion and --machine:vbox as the configured option with vbox as the default for mac / windows. We will then accept it.

@zaps
Copy link
Author

zaps commented Mar 14, 2016

Will do.
I noticed there already is a --machine switch for specifying the name of the machine so right now, running for example che.sh --machine:vbox will create a docker-machine with name 'vbox'.

Instead, could we add another option, maybe --machine-driver to specify the driver type?
I.e. --machine-driver:fusion. If the option is not given it would default to vbox.

Otherwise, we'd have to do something like --machine:name=myCheMachine,driver=fusion. And again if the argument isn't provided it would default to default/vbox.

@TylerJewell
Copy link

Ahhh didn't notice that --machine was already used. Yes --machine-driver:vbox and --machine-driver:fusion is better approach.

Signed-off-by: Michael Masi <michael@eclipse.masi.cc>
@zaps
Copy link
Author

zaps commented Mar 15, 2016

ok all set!

TylerJewell pushed a commit that referenced this pull request Mar 15, 2016
add VMware Fusion support
@TylerJewell TylerJewell merged commit f9b4fb5 into eclipse-che:master Mar 15, 2016
@TylerJewell
Copy link

Looks good to me. Past all my tests. Congrats on the first merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants