Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Traefik's docker.network label to fix multiuser single_port #7170

Merged
1 commit merged into from
Nov 3, 2017
Merged

Added Traefik's docker.network label to fix multiuser single_port #7170

1 commit merged into from
Nov 3, 2017

Conversation

hickey
Copy link
Contributor

@hickey hickey commented Nov 2, 2017

What does this PR do?

Attempts to fix the gateway timeout issue when running multiuser single_port mode.

What issues does this PR fix or reference?

#7059

Release Notes

Docs PR

@codenvy-ci
Copy link

Can one of the admins verify this patch?

Added Traefik's docker.network label to fix multiuser single_port
766c567 
Signed-off-by: Gerard Hickey <Gerard.Hickey@smartsheet.com>
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@hickey hickey force-pushed the bugfix/multiuser-single-port branch from 2ed2d61 to 766c567 Compare November 2, 2017 23:31
@benoitf benoitf requested a review from a user November 3, 2017 08:26
benoitf
benoitf approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's being discussed on issue as well on #7059 but this PR is ok for me

@ghost ghost added this to the 5.21.0 milestone Nov 3, 2017
@ghost ghost merged commit 639dd58 into eclipse-che:master Nov 3, 2017
@benoitf benoitf added the kind/question Questions that haven't been identified as being feature requests or bugs. label Nov 6, 2017
skabashnyuk pushed a commit that referenced this pull request Nov 7, 2017
@hickey @skabashnyuk
Added Traefik's docker.network label to fix multiuser single_port (#7170
7e848b1 
)

Signed-off-by: Gerard Hickey <Gerard.Hickey@smartsheet.com>
@pixystone
Copy link

It seems that traefik.che.docker.network is an invalid property.

Available properties are: traefik/traefik#1257 (comment)

traefik.<service-name>.port
traefik.<service-name>.weight
traefik.<service-name>.protocol
traefik.<service-name>.frontend.backend
traefik.<service-name>.frontend.entryPoints
traefik.<service-name>.frontend.rule
traefik.<service-name>.frontend.passHostHeader
traefik.<service-name>.frontend.priority
traefik.<service-name>.frontend.rule

I think traefik.docker.network is the proper name.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@riuvshin riuvshin riuvshin approved these changes

Assignees
No one assigned
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Milestone
5.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hickey @codenvy-ci @pixystone @benoitf @riuvshin