Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed scl enable rh-nodejs dependency (centos-nodejs) #7209

Merged
merged 2 commits into from
Nov 8, 2017

Conversation

JPinkney
Copy link
Contributor

@JPinkney JPinkney commented Nov 6, 2017

What does this PR do?

Removes the scl enable rh-nodejs dependency in centos-nodejs stack

What issues does this PR fix or reference?

As of eclipse-che/che-dockerfiles@8e70296 we no longer have to preface commands with scl enable rh-nodejs

Release Notes

scl enable rh-nodejs removed from run command in centos-nodejs stack

Docs PR

@codenvy-ci
Copy link

Can one of the admins verify this patch?

1 similar comment
@codenvy-ci
Copy link

Can one of the admins verify this patch?

Signed-off-by: jpinkney <josh.pinkney@mail.utoronto.ca>
@JPinkney JPinkney changed the title Removed scl enable rh-nodejs dependency Removed scl enable rh-nodejs dependency (centos-stack) Nov 6, 2017
@JPinkney JPinkney changed the title Removed scl enable rh-nodejs dependency (centos-stack) Removed scl enable rh-nodejs dependency (centos-nodejs) Nov 6, 2017
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 6, 2017
Signed-off-by: jpinkney <josh.pinkney@mail.utoronto.ca>
@l0rd l0rd added this to the 5.21.0 milestone Nov 7, 2017
@l0rd
Copy link
Contributor

l0rd commented Nov 7, 2017

cc @dharmit

@benoitf
Copy link
Contributor

benoitf commented Nov 7, 2017

a PR will be required for che6 branch as well

@l0rd l0rd merged commit a17f120 into eclipse-che:master Nov 8, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants