Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynaModule plugin test: Avoid timestamp usage when copying dependency + sorting files issue #7218

Merged
merged 2 commits into from
Nov 7, 2017
Merged

DynaModule plugin test: Avoid timestamp usage when copying dependency + sorting files issue #7218

merged 2 commits into from
Nov 7, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 7, 2017

backport of che6 PR #7206 to master

What does this PR do?

-Use a fixed name for the dependency instead of using timestamped dependency artifact name if the dependency is downloaded from nexus

  • Apply another filter for getting test module class as filesystem may not following lexicographical order

What issues does this PR fix or reference?

#7140

Release Notes

N/A

Docs PR

N/A

@benoitf
Avoid that copy dependency is copying artifact with timestamp
677de2e 
Change-Id: Ia37e3c141298ef210d71204d8296a0a925bce8de
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
@benoitf
specify more path of the file to search to also match on filesystem n…
40d7c9a 
…ot sorting by default with lexicographical order

Change-Id: Ib2eb1f5b5601542a56a6dede103a699c370a0d69
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
@benoitf benoitf self-assigned this Nov 7, 2017
@benoitf
Copy link
Contributor Author

benoitf commented Nov 7, 2017

ci-build

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 7, 2017
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4310/

@benoitf benoitf merged commit b5919a9 into master Nov 7, 2017
@benoitf benoitf deleted the fix-dynamodule-build branch November 7, 2017 08:35
@benoitf benoitf added this to the 5.21.0 milestone Nov 7, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

Assignees

@benoitf benoitf

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
5.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benoitf @codenvy-ci @skabashnyuk